Skip to content

Commit

Permalink
Auto merge of rust-lang#78439 - lzutao:rm-clouldabi, r=Mark-Simulacrum
Browse files Browse the repository at this point in the history
Drop support for all cloudabi targets

`cloudabi` is a tier-3 target, and [it is no longer being maintained upstream][no].

This PR drops supports for cloudabi targets. Those targets are:
* aarch64-unknown-cloudabi
* armv7-unknown-cloudabi
* i686-unknown-cloudabi
* x86_64-unknown-cloudabi

Since this drops supports for a target, I'd like somebody to tag `relnotes` label to this PR.

Some other issues:
* The tidy exception for `cloudabi` crate is still remained because
  * `parking_lot v0.9.0` and `parking_lot v0.10.2` depends on `cloudabi v0.0.3`.
  * `parking_lot v0.11.0` depends on `cloudabi v0.1.0`.

[no]: https://github.com/NuxiNL/cloudabi#note-this-project-is-unmaintained
  • Loading branch information
bors committed Nov 23, 2020
2 parents 1464dce + 4b698f2 commit e5fddb6
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 34 deletions.
2 changes: 1 addition & 1 deletion clippy_lints/src/attrs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static UNIX_SYSTEMS: &[&str] = &[
];

// NOTE: windows is excluded from the list because it's also a valid target family.
static NON_UNIX_SYSTEMS: &[&str] = &["cloudabi", "hermit", "none", "wasi"];
static NON_UNIX_SYSTEMS: &[&str] = &["hermit", "none", "wasi"];

declare_clippy_lint! {
/// **What it does:** Checks for items annotated with `#[inline(always)]`,
Expand Down
5 changes: 1 addition & 4 deletions tests/ui/mismatched_target_os_non_unix.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
#![warn(clippy::mismatched_target_os)]
#![allow(unused)]

#[cfg(target_os = "cloudabi")]
fn cloudabi() {}

#[cfg(target_os = "hermit")]
fn hermit() {}

Expand All @@ -16,7 +13,7 @@ fn wasi() {}
fn none() {}

// list with conditions
#[cfg(all(not(any(windows, target_os = "cloudabi")), target_os = "wasi"))]
#[cfg(all(not(windows), target_os = "wasi"))]
fn list() {}

// windows is a valid target family, should be ignored
Expand Down
5 changes: 1 addition & 4 deletions tests/ui/mismatched_target_os_non_unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
#![warn(clippy::mismatched_target_os)]
#![allow(unused)]

#[cfg(cloudabi)]
fn cloudabi() {}

#[cfg(hermit)]
fn hermit() {}

Expand All @@ -16,7 +13,7 @@ fn wasi() {}
fn none() {}

// list with conditions
#[cfg(all(not(any(windows, cloudabi)), wasi))]
#[cfg(all(not(windows), wasi))]
fn list() {}

// windows is a valid target family, should be ignored
Expand Down
35 changes: 10 additions & 25 deletions tests/ui/mismatched_target_os_non_unix.stderr
Original file line number Diff line number Diff line change
@@ -1,51 +1,36 @@
error: operating system used in target family position
--> $DIR/mismatched_target_os_non_unix.rs:6:1
|
LL | #[cfg(cloudabi)]
| ^^^^^^--------^^
| |
| help: try: `target_os = "cloudabi"`
|
= note: `-D clippy::mismatched-target-os` implied by `-D warnings`

error: operating system used in target family position
--> $DIR/mismatched_target_os_non_unix.rs:9:1
|
LL | #[cfg(hermit)]
| ^^^^^^------^^
| |
| help: try: `target_os = "hermit"`
|
= note: `-D clippy::mismatched-target-os` implied by `-D warnings`

error: operating system used in target family position
--> $DIR/mismatched_target_os_non_unix.rs:12:1
--> $DIR/mismatched_target_os_non_unix.rs:9:1
|
LL | #[cfg(wasi)]
| ^^^^^^----^^
| |
| help: try: `target_os = "wasi"`

error: operating system used in target family position
--> $DIR/mismatched_target_os_non_unix.rs:15:1
--> $DIR/mismatched_target_os_non_unix.rs:12:1
|
LL | #[cfg(none)]
| ^^^^^^----^^
| |
| help: try: `target_os = "none"`

error: operating system used in target family position
--> $DIR/mismatched_target_os_non_unix.rs:19:1
|
LL | #[cfg(all(not(any(windows, cloudabi)), wasi))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: try
|
LL | #[cfg(all(not(any(windows, target_os = "cloudabi")), wasi))]
| ^^^^^^^^^^^^^^^^^^^^^^
help: try
--> $DIR/mismatched_target_os_non_unix.rs:16:1
|
LL | #[cfg(all(not(any(windows, cloudabi)), target_os = "wasi"))]
| ^^^^^^^^^^^^^^^^^^
LL | #[cfg(all(not(windows), wasi))]
| ^^^^^^^^^^^^^^^^^^^^^^^^----^^^
| |
| help: try: `target_os = "wasi"`

error: aborting due to 5 previous errors
error: aborting due to 4 previous errors

0 comments on commit e5fddb6

Please sign in to comment.