-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cython coverage plugin #188
Add Cython coverage plugin #188
Conversation
I've updated |
This should make it possible to do coverage measurement with the meson build. For now my patched Cython is needed:
Then
should give you the coverage report. Let me know if it doesn't work. |
Oh cool! I'll have a play tomorrow, although now I've added the two types on my TODO list I probably have other implementation things to help people with! |
Wonderful work thanks! It's working for me |
This only works with a small patch to Cython.
You can install the patched Cython from my fork with:
(I am about to open a Cython PR from that branch.)
Then to make a coverage enabled build you need:
Then to run the tests and measure coverage it is:
Ideally once Cython is patched we can somehow put this altogether as a
spin coverage
command to make it nice and easy.I basically had to rewrite Cython's coverage plugin, largely from scratch. I think that the only part left from the original after I rewrote everything is the
parse_cfile_lines
function.For now we can merge this to python-flint but ideally this would be upstreamed to either spin or Cython I think so I will follow up with that after.