Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature: multi user #427

Merged
merged 3 commits into from
May 13, 2018
Merged

add feature: multi user #427

merged 3 commits into from
May 13, 2018

Conversation

cppmajor
Copy link

Each user uses its own schema for isolation.
每个用户只能使用相应的schema,从而做到用户隔离;

@flike
Copy link
Owner

flike commented May 2, 2018

Thanks,I will review your code later!

@flike
Copy link
Owner

flike commented May 7, 2018

重新加载配置,特别是分表规则,非常有用

@IT-xiaoge
Copy link

这两个功能都非常有用,可以动态加载配置文件,以后机器扩容就不需要重启了


//reset nodes: old nodes offline (stop check thread)
for _, n := range s.nodes {
n.Online = false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要设置成offline?

@flike
Copy link
Owner

flike commented May 13, 2018

@cppmajor ,我看了你提交的这两个feature,写的非常好,后续能否补充一下单元测试和更新config文件的文档。再次感谢!

@flike flike merged commit a8db49d into flike:master May 13, 2018
@flike
Copy link
Owner

flike commented May 13, 2018

现在存在的问题是:表可以看到,但查询或写入会失败。可以优化一下,表直接看不到。在proxy层过滤一下。方便的话,请加一下我的微信:flikechen。有关这几个feature的问题,向你咨询一下。谢谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants