Skip to content

Finally found the horrific memory leak! #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n0nag0n merged 1 commit into from
Jul 19, 2025
Merged

Finally found the horrific memory leak! #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions flight/Engine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,12 @@ public function _start(): void
if ($this->requestHandled === false) {
// not doing much here, just setting the requestHandled flag to true
$this->requestHandled = true;

// Allow filters to run
// This prevents multiple after events from being registered
$this->after('start', function () use ($self) {
$self->stop();
});
} else {
// deregister the request and response objects and re-register them with new instances
$this->unregister('request');
Expand All @@ -535,11 +541,6 @@ public function _start(): void
$response = $this->response();
$router = $this->router();

// Allow filters to run
$this->after('start', function () use ($self) {
$self->stop();
});

if ($response->v2_output_buffering === true) {
// Flush any existing output
if (ob_get_length() > 0) {
Expand Down