Skip to content

Conversation

@pierresh
Copy link

That is much more comfortable than restarting tests manually when a change is made

The command to run tests remains unchanged:

composer test

@n0nag0n
Copy link
Collaborator

n0nag0n commented May 2, 2025

I love the idea, we just gotta get it working with php 7.4 and php 8. Maybe try altering the composer.json file to "spatie/phpunit-watcher": "^1.23", or "spatie/phpunit-watcher": "^1.23 || ^1.24", instead? The other thing is that I would change it to keep composer test the way it is, but add a composer test-watch or something like that cause I can see a world where watching the repo breaks the build somehow. The only other thing I thought about was this change is cool (I didn't even know it was a think) but would it make more sense in the skeleton repo with some added docs in the documentation to tell people about it?

@pierresh pierresh force-pushed the phpunit-watcher branch from 28e9412 to 1da6a7b Compare May 2, 2025 14:53
That is much more comfortable than restarting tests manually when a change is made

The command to run tests during development remained unchanged:

composer test
@pierresh pierresh force-pushed the phpunit-watcher branch from 1da6a7b to 863282a Compare May 2, 2025 14:59
@pierresh
Copy link
Author

pierresh commented May 2, 2025

I love the idea, we just gotta get it working with php 7.4 and php 8. Maybe try altering the composer.json file to "spatie/phpunit-watcher": "^1.23", or "spatie/phpunit-watcher": "^1.23 || ^1.24", instead? The other thing is that I would change it to keep composer test the way it is, but add a composer test-watch or something like that cause I can see a world where watching the repo breaks the build somehow. The only other thing I thought about was this change is cool (I didn't even know it was a think) but would it make more sense in the skeleton repo with some added docs in the documentation to tell people about it?

I found a way to fix the conflict of required versions (1.23 / 1.24) depending on the PHP version.

The build failed because the github actions also relied on composer test. And with phpunit-watcher, it never stops actually, it was waiting for changes :). That is why the build failed after a while (once a timeout was reached)

I did the opposite, I did an alias dedicated to Github actions (composer test-ci) and kept composer test for phpsunit-watcher by default.

@n0nag0n n0nag0n merged commit aaf9f62 into flightphp:master May 6, 2025
6 checks passed
@n0nag0n
Copy link
Collaborator

n0nag0n commented May 6, 2025

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants