Skip to content

fix: preserve negative zero in Float32Array and Float64Array #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greymoth-jp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve negative zero in Float32Array and Float64Array #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,31 @@ describe('stringify & parse', () => {
},
},

'preserves negative zero in Float64Array and Float32Array': {
input: {
a: new Float64Array([-0, 0, -0, 1]),
b: new Float32Array([-0, 2]),
},
output: {
a: ['-0', 0, '-0', 1],
b: ['-0', 2],
},
outputAnnotations: {
values: {
a: [['typed-array', 'Float64Array']],
b: [['typed-array', 'Float32Array']],
},
},
customExpectations: (value: any) => {
expect(Object.is(value.a[0], -0)).toBe(true);
expect(Object.is(value.a[1], 0)).toBe(true);
expect(Object.is(value.a[2], -0)).toBe(true);
expect(value.a[3]).toBe(1);
expect(Object.is(value.b[0], -0)).toBe(true);
expect(value.b[1]).toBe(2);
},
},

'works with BigInt typed arrays': {
input: {
a: new BigInt64Array([1n, 2n, -3n, 9007199254740993n]),
Expand Down
4 changes: 4 additions & 0 deletions src/transformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ const typedArrayRule = compositeTransformation(
if (Number.isNaN(n)) return 'NaN';
if (n === Infinity) return 'Infinity';
if (n === -Infinity) return '-Infinity';
// Negative zero also doesn't survive JSON (JSON.stringify(-0) === '0'),
// so it's stored as a string like the other special float values.
if (n === 0 && 1 / n === -Infinity) return '-0';
}
return n;
}),
Expand All @@ -271,6 +274,7 @@ const typedArrayRule = compositeTransformation(
if (n === 'NaN') return NaN;
if (n === 'Infinity') return Infinity;
if (n === '-Infinity') return -Infinity;
if (n === '-0') return -0;
return n as number;
});

Expand Down