Fix initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut destination lacks ‘nonstring’ attribute
|
I think #261 is the simplest fix. |
Author
|
@gtjoseph I agree, just sacrifices two bytes ;-) |
|
Yeah it's 2025 and we're well beyond Bill Gates's "No one will ever need more than 640K of RAM" statement from back in the '80s. :) |
|
There is another option for solving this that hasn't been considered and does not "waste" bytes: adding |
That's gcc specific and not supported by other compilers such as clang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it could be fixed easier, but this would at least fixes the warning.