Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnv target fixes #1383

Merged
merged 11 commits into from
Feb 9, 2024
Merged

rnv target fixes #1383

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e9a65f
fixes https://github.com/flexn-io/renative/issues/1378
pavjacko Feb 6, 2024
4df4c7a
fix https://github.com/flexn-io/renative/issues/1379 (-p android)
pavjacko Feb 6, 2024
c5ea85c
fix https://github.com/flexn-io/renative/issues/1382 (-p android)
pavjacko Feb 6, 2024
0c651ae
fix https://github.com/flexn-io/renative/issues/1381
pavjacko Feb 6, 2024
2d3fff5
fixes https://github.com/flexn-io/renative/issues/1382 (-p ios)
pavjacko Feb 6, 2024
f82ade9
correct grammar
pavjacko Feb 6, 2024
158e523
Merge branch 'release/1.0' of github.com:pavjacko/renative into fix/r…
mihaiblaga89 Feb 8, 2024
77ea71f
ask where to run if tizen target launch and none selected
mihaiblaga89 Feb 8, 2024
39571dc
test
mihaiblaga89 Feb 9, 2024
ced90be
unionize CLI calling for tizen, proper handle of error
mihaiblaga89 Feb 9, 2024
35f2380
add handling for tizen already running
mihaiblaga89 Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fixes #1378
  • Loading branch information
@pavjacko
pavjacko committed Feb 6, 2024
commit 8e9a65f4958c5d779c0cd7d38a155956717350e1
2 changes: 1 addition & 1 deletion packages/engine-core/src/tasks/task.rnv.target.launch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const taskRnvTargetLaunch: RnvTaskFn = async (c, parentTask, originTask)
options.push({ name: `${workspaceTarget} (global default)`, value: workspaceTarget });
}

options.push({ name: 'Pick from available targets...', value: null });
options.push({ name: 'Pick from available targets...', value: true });

const { selectedOption } = await inquirerPrompt({
name: 'selectedOption',
Expand Down