Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip --yes for nameless prompts #1317

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Don't skip --yes for nameless prompts #1317

merged 2 commits into from
Dec 22, 2023

Conversation

mihaiblaga89
Copy link
Contributor

Description

  • Don't skip --yes for nameless prompts. Example:
const { confirm } = await inquirerPrompt({
    type: 'confirm',
    message: `Install ${key}?`,
    warningMessage: `Plugin ${chalk().white(key)} source:${chalk().white(scope)} required by ${chalk().red(
        parentKey
    )} is not installed`,
});

Related issues

Npm releases

n/a

@pavjacko
Merge branch 'release/1.0' into fix/ci_prompt
8efed11 
* release/1.0:
  fix ut mock for exec tests
  replace interactive option with presets
  make logging colors more subtle
  do not add child process to kill list if detached mode, add exec presets, test out executeAsync insteaf of execCLI
@pavjacko pavjacko self-assigned this Dec 22, 2023
@pavjacko pavjacko merged commit bdba765 into release/1.0 Dec 22, 2023
@pavjacko pavjacko deleted the fix/ci_prompt branch December 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavjacko pavjacko pavjacko approved these changes

@ElenaDiachenko ElenaDiachenko Awaiting requested review from ElenaDiachenko

Assignees

@pavjacko pavjacko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaiblaga89 @pavjacko