Update local cost estimator for latest task-spec#1626
Open
elliottslaughter wants to merge 3 commits intoflexflow:masterfrom
Open
Update local cost estimator for latest task-spec#1626elliottslaughter wants to merge 3 commits intoflexflow:masterfrom
elliottslaughter wants to merge 3 commits intoflexflow:masterfrom
Conversation
elliottslaughter
force-pushed
the
cost-estimator
branch
5 times, most recently
from
8323db0 to
6eee3b3
Compare
elliottslaughter
force-pushed
the
cost-estimator
branch
from
6eee3b3 to
59f6f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on top of #1625, must merge that one first.
Updates the local cost estimator for recent task-spec and local-execution updates.
The new local cost estimator is implemented in terms of
ComputationGraphInstancepublic APIs only, so it doesn't need to be aware of any other local-execution internals.The tests have been updated and pass on CPU and GPU.
This change is