-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement get_pcg_series_parallel_decomposition
#1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 128 of 128 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marsella8)
lib/compiler/test/src/compiler/machine_mapping/get_tensor_set_movement_across_split.cc
line 13 at r1 (raw file):
using namespace ::FlexFlow; bool isDebuggerActive() {
Do you want to move it to somewhere under utils
? or if it was just used temporarily, just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lockshaw and @Marsella8)
Description of changes:
get_pcg_series_parallel_decomposition
TensorAttrs
toWeightAttrs
ParamSync
for nowadd_layer
functions forComputationGraph
andParallelComputationGraph
TensorShape
field inInputAttrs
, forcing allInputAttrs
to be non-parallelized for nowRelated Issues:
Linked Issues:
Issues closed by this PR:
This change is