Fix issues with long testing times on Windows caused by log rotation from multiple threads #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/conftest.py
Outdated
Comment on lines
13
to
14
| log_dir = flow360_dir + "logs" | ||
| log_path = os.path.join(log_dir, "flow360_temp.log") |
There was a problem hiding this comment.
log_dir = os.path.join(flow360_dir, "logs")
or combine with next line.
We should clean up after tests. Would suggest to log to a temp file which will be deleted at the end of the test
There was a problem hiding this comment.
Fixed in dbe1d20, only logs from test_log.py are not temporary and remain in a separate small file that is cleaned for every test run.
awkrupka
force-pushed
the
andrzej/windows_logging_fix
branch
2 times, most recently
from
6082f1f to
dbe1d20
Compare
maciej-flexcompute
approved these changes
Oct 4, 2023
awkrupka
force-pushed
the
andrzej/windows_logging_fix
branch
from
397b2a3 to
75727d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the past two months testing times on Windows were excessively long - this was caused by OS-specific restrictions on file operations from multiple threads. Since this issue is test-specific a separate log file for test output has been created. Additionally the maximum file size before log rotation was small (10kB) and has been increased to 1MB. This brings Windows test performance in line with other systems.