Support volume zones and aeroacoustic output - #60
Merged
Conversation
awkrupka
force-pushed
the
maciej/support_volume_zones
branch
from
October 2, 2023 15:05
20d7dbd to
257c4dc
Compare
awkrupka
force-pushed
the
maciej/support_volume_zones
branch
from
October 2, 2023 15:07
257c4dc to
5aee77e
Compare
| animation_frequency: Optional[PositiveInt] = pd.Field(alias="animationFrequency") | ||
| animation_frequency_offset: Optional[int] = pd.Field(alias="animationFrequencyOffset") | ||
| patch_type: Optional[str] = pd.Field("solid", const=True) | ||
| observers: List[Coordinate] = pd.Field(alias="observers") |
Collaborator
There was a problem hiding this comment.
alias seems to be redundant here
|
|
||
| animation_frequency: Optional[PositiveInt] = pd.Field(alias="animationFrequency") | ||
| animation_frequency_offset: Optional[int] = pd.Field(alias="animationFrequencyOffset") | ||
| patch_type: Optional[str] = pd.Field("solid", const=True) |
Collaborator
There was a problem hiding this comment.
it needs alias patchType
| >>> aeroacoustics = AeroacousticOutput() | ||
| """ | ||
|
|
||
| animation_frequency: Optional[PositiveInt] = pd.Field(alias="animationFrequency") |
Collaborator
There was a problem hiding this comment.
animationFrequency can be positive int or -1. I think Union with Literal can work here
Contributor
Author
There was a problem hiding this comment.
Fixed in a01150b, added additional unit tests for -1 and other negative numbers
|
|
||
| Example | ||
| ------- | ||
| >>> aeroacoustics = AeroacousticOutput() |
Collaborator
There was a problem hiding this comment.
lets give example that means something, for example observers=[(0, 0, 0), (0, 0, 1)]
Contributor
Author
There was a problem hiding this comment.
Fixed in a01150b, also added minimal entries for optional parameters in the documentation
maciej-flexcompute
approved these changes
Oct 3, 2023
maciej-flexcompute
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More complete volume zone tests were added, aeroacoustic output has been defined based on the JSON Schema.
Also incorporates a temporary fix causing extremely long test running times on Windows caused by log file writes - this issue needs to be addressed separately.