added destination to case.results.download() functionality #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinlin-flex
suggested changes
Jul 26, 2023
| @@ -27,15 +27,14 @@ | |||
| print(case.results.minmax_state.raw) | |||
|
|
|||
| # download all result files of the case: | |||
| case.results.download_manager(all=True) | |||
| downloaded_files = case.results.download(all=True, destination=case.name) | |||
| print(downloaded_files) | |||
There was a problem hiding this comment.
should we print, or refactor to use log [Potentially allow centralized control over printing by setting logging levels]
There was a problem hiding this comment.
this is part of examples. I think it is better to use print in examples as these will be run and modify by users so they will not be familiar with log.
jinlin-flex
reviewed
Jul 26, 2023
flow360/cloud/s3_utils.py
Outdated
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| from ..environment import Env | |||
| from ..exceptions import CloudFileError | |||
There was a problem hiding this comment.
it seems like CloudFileError is unused
jinlin-flex
approved these changes
Jul 26, 2023
…ther download methods applied PR comments fixed black removed unused import
maciej-flexcompute
force-pushed
the
maciej/FLPY-3/download
branch
from
329d086 to
75809b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://flow360.atlassian.net/browse/FLPY-3