-
Notifications
You must be signed in to change notification settings - Fork 9
[FXC-3494] Text expression [WIP][25.8] #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benflexcompute
wants to merge
32
commits into
main
Choose a base branch
from
BenY/FXC-3494/TextExpression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1466) * [FXC-3529] Introduce EntitySelector data model into EntityList * Remove unnecessary changes
* Added the get_entity_database_for_selectors * WIP * Added support for generic Glob patterns * Ready * Added case sensitivity on Windows
* Finished implementation * Removed equals and not_equals * Self review * Changed discriminator to be confromal to the user API
…alidation (#1534) * Update the service to ensure expanding before the validation * Fixed unit test * Added support for assigning EntitySelector to EntityList, also updated validations to defer stored_entities related checks to validate_model() stage * Enabled pure selector input * fixed lint * Refactor on entity test structure * Added removal of matched entities before submission * Reviewed * Fixed pylint
…tion before constructing ParamsValidationInfo() (#1607) * fix(): Moving the preprocessing of dict before validaiton into a function before constructing ParamsValidationInfo() * moving things around * Fix lint
* Added description and selector_id * resolve lintintg * Fixed linting
* Added description and selector_id * resolve lintintg * Fixed linting * Fixed linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.