Release 23.3.2+ features hidden #123

awkrupka · 2024-01-15T12:05:24Z

No description provided.

… features turned on only in tests)

maciej-flexcompute · 2024-01-15T12:52:09Z

flow360/component/flow360_params/unit_system.py

+    if Flags.beta_features():
+        heat_flux: HeatFluxType = pd.Field()


this is non blocking, no need to mark as beta feature

Reverted, was listed in PRs to remove from 23.3.2 so i figured it should be blocked

maciej-flexcompute · 2024-01-15T12:52:21Z

flow360/component/flow360_params/unit_system.py

+    if Flags.beta_features():
+        _dim_names.append("heat_flux")


this is non blocking, no need to mark as beta feature

maciej-flexcompute · 2024-01-15T12:52:41Z

flow360/component/flow360_params/unit_system.py

+if Flags.beta_features():
+    flow360_heat_flux_unit = Flow360HeatFluxUnit()


this is non blocking, no need to mark as beta feature

maciej-flexcompute · 2024-01-15T12:52:52Z

flow360/component/flow360_params/unit_system.py

+    if Flags.beta_features():
+        base_heat_flux: float = pd.Field(np.inf, target_dimension=Flow360HeatFluxUnit)


this is non blocking, no need to mark as beta feature

maciej-flexcompute · 2024-01-15T12:52:57Z

flow360/component/flow360_params/unit_system.py

+        if Flags.beta_features():
+            conversion_system["heat_flux"] = "flow360_heat_flux_unit"


this is non blocking, no need to mark as beta feature

maciej-flexcompute · 2024-01-15T12:53:05Z

flow360/component/flow360_params/unit_system.py

+    if Flags.beta_features():
+        heat_flux: HeatFluxType = pd.Field(exclude=True)


this is non blocking, no need to mark as beta feature

maciej-flexcompute · 2024-01-15T13:10:21Z

flow360/component/flow360_params/conversions.py

+    if Flags.beta_features():
+
+        def get_base_heat_flux():
+            base_density = get_base_density()
+            base_velocity = get_base_velocity()
+            base_heat_flux = base_density * base_velocity**3

-        return base_heat_flux
+            return base_heat_flux


no need to mark this as beta feature

maciej-flexcompute · 2024-01-15T13:13:01Z

flow360/component/flow360_params/turbulence_quantities.py

 """
 Turbulence quantities parameters
 """
-from abc import ABCMeta
-from typing import Optional, Union
+from globals.flags import Flags


can we just import this file under beta_features() but its definition leave unchanged?

We could, but this way the user will be able to import it directly (not from flow360 base module but from flow360.component.flow360_params.turbulence_quantities) and still use it which may not be what we want

maciej-flexcompute · 2024-01-15T13:15:37Z

globals/flags.py

maybe we can just use ENV variable to set flag? Then we can run tests in both scenarios

We could explore this, but I think what we want would be

Set beta_features to True

Import flow360, run tests

Set beta_features to False

Import flow360 again, run tests

and its step 4 that's the main issue, as we need to reimport flow360 at some point when running tests. ENV variables would have the advantage of not requiring the globals.flags module, at the cost of setting the state permanently (right now feature flags are disabled by default unless we explicitly set them before import)

it would work if we ran a different command like

(set variable) && pytest -rA && (set variable) && pytest -rA

Changed to environment variable: to run tests with the beta_features on we run

FLOW360_BETA_FEATURES=True pytest -rA

maciej-flexcompute · 2024-01-15T17:28:19Z

flow360/component/flow360_params/boundaries.py

 from .unit_system import VelocityType

+if os.environ.get("FLOW360_BETA_FEATURES", False):


this is not exactly what I had in mind. Can we still use some nice wrapper, like flags.beta_features but inside it parse env variable?

Fixed, added a wrapper class so we still call Flags.beta_feature() in checks

maciej-flexcompute · 2024-01-16T14:20:28Z

config/flags.py

this file is outside flow360. When publishing to PyPI this path will be excluded so I think the package will not be able to init

awkrupka and others added 10 commits January 11, 2024 13:11

[RELEASE 23.3.2] Ramp steps for mass outflow/inflow hidden

1747240

[RELEASE 23.3.2] Turbulence quantities hidden

1d0eb33

Refactored release 23.3.2 features to use dynamic feature flags (beta…

1269872

… features turned on only in tests)

[RELEASE 23.3.2] Linear solver rename hidden

878eba7

[RELEASE 23.3.2] Supersonic inflow reformat hidden

d208215

[RELEASE 23.3.2] Supersonic inflow hidden

2b95e18

[RELEASE 23.3.2] Heat flux hidden

7d0d628

[RELEASE 23.3.2] Aeroacoustic per surface output hidden

baf7117

Merge branch 'develop' into release-23.3.2

b498b75

Regenerated schema files

fe8029c

maciej-flexcompute reviewed Jan 15, 2024

View reviewed changes

awkrupka added 2 commits January 15, 2024 15:26

Revert heat flux changes

4250977

Moved beta feature toggle to env variables

b530f6d

maciej-flexcompute reviewed Jan 15, 2024

View reviewed changes

Added wrapper for beta features

e2ccc08

awkrupka force-pushed the release-23.3.2 branch from 741d519 to e2ccc08 Compare January 16, 2024 11:35

Merge branch 'develop' into release-23.3.2

24f2017

awkrupka force-pushed the release-23.3.2 branch from f75ec81 to 24f2017 Compare January 16, 2024 11:58

maciej-flexcompute reviewed Jan 16, 2024

View reviewed changes

Added CLI for beta feature flags

3acf056

awkrupka force-pushed the release-23.3.2 branch from 421696b to 3acf056 Compare January 17, 2024 11:50

Merge branch 'develop' into release-23.3.2

683d1ce

awkrupka force-pushed the release-23.3.2 branch 2 times, most recently from 7f803b3 to cb3a55b Compare January 18, 2024 01:56

Fix bool evaluation from env variable

faa3173

awkrupka force-pushed the release-23.3.2 branch from cb3a55b to faa3173 Compare January 18, 2024 02:00

maciej-flexcompute approved these changes Jan 18, 2024

View reviewed changes

maciej-flexcompute merged commit e63486e into develop Jan 18, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 23.3.2+ features hidden #123

Release 23.3.2+ features hidden #123

awkrupka commented Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 15, 2024 •

edited

Loading

awkrupka Jan 15, 2024

maciej-flexcompute Jan 15, 2024

awkrupka Jan 16, 2024

maciej-flexcompute Jan 16, 2024

		if Flags.beta_features():
		heat_flux: HeatFluxType = pd.Field()

		if Flags.beta_features():
		flow360_heat_flux_unit = Flow360HeatFluxUnit()

		if Flags.beta_features():
		base_heat_flux: float = pd.Field(np.inf, target_dimension=Flow360HeatFluxUnit)

		if Flags.beta_features():
		conversion_system["heat_flux"] = "flow360_heat_flux_unit"

		if Flags.beta_features():
		heat_flux: HeatFluxType = pd.Field(exclude=True)

		from .unit_system import VelocityType

		if os.environ.get("FLOW360_BETA_FEATURES", False):

Release 23.3.2+ features hidden #123

Release 23.3.2+ features hidden #123

Conversation

awkrupka commented Jan 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awkrupka Jan 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awkrupka Jan 15, 2024 •

edited

Loading