-
Notifications
You must be signed in to change notification settings - Fork 590
fix(flet-map): PolylineLayer not showing up in UI
#5794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…es` and `PolylineMarker`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
0fd9108
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8c25517.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-polylinelayer.flet-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR includes documentation improvements for enum values and a bug fix in the polyline layer control. The changes enhance code clarity and correct incorrect references.
- Documentation added/improved for
ImageRepeatandVisualDensityenum values - Fixed incorrect references in
polyline_layer.dartfrom "polygons"/"PolygonMarker" to "polylines"/"PolylineMarker" - Minor formatting cleanup in type alias documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
sdk/python/packages/flet/src/flet/controls/types.py |
Added documentation strings for ImageRepeat enum values and improved formatting of VisualDensity enum documentation |
sdk/python/packages/flet-map/src/flutter/flet_map/lib/src/polyline_layer.dart |
Fixed incorrect children selector and type check from "polygons"/"PolygonMarker" to "polylines"/"PolylineMarker" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please check copilot comments here: https://github.com/flet-dev/flet/pull/5794/files#diff-dd984269d51a00ebf6d86e01e0dc5cd02cfd6f00a9451245045712142894270f |
Fix #5776
Summary by Sourcery
Fix polyline rendering issue in Flet map and standardize enum documentation
Bug Fixes:
Enhancements: