Skip to content

v1: patches + improvements #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 3, 2025
Merged

v1: patches + improvements #5265

merged 11 commits into from
May 3, 2025

Conversation

ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented May 1, 2025

Summary by Sourcery

Refactor and improve storage paths, responsive design, and control handling across Dart and Python implementations of the Flet framework

New Features:

  • Added ResponsiveRowBreakpoint enum in Python
  • Introduced platform-specific method checks for storage paths

Enhancements:

  • Redesigned StoragePaths service to use invoke method pattern
  • Improved responsive row breakpoint handling
  • Simplified control and shader mask implementations
  • Added platform-specific method checks in Python implementation

Chores:

  • Cleaned up unused imports
  • Simplified error handling and control logic

@ndonkoHenri ndonkoHenri changed the title v1: opat v1: patches + improvements May 1, 2025
@ndonkoHenri ndonkoHenri marked this pull request as draft May 1, 2025 12:39
@@ -49,6 +47,6 @@ def main(page: ft.Page):
"""

shader: Gradient
content: Optional[Control] = None
blend_mode: Optional[BlendMode] = None
content: OptionalControl = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not completely sold we should introduce a lot of "specific" types, like OptionalControl where you have to go there and see what that type really means. Moreover, starting from Python 3.11 it has nicer syntax: Control | None, so eventually we won't need that at all.

@ndonkoHenri ndonkoHenri marked this pull request as ready for review May 3, 2025 00:36
@FeodorFitsner FeodorFitsner mentioned this pull request May 3, 2025
11 tasks
@FeodorFitsner FeodorFitsner merged commit 14d029c into v1 May 3, 2025
2 checks passed
@FeodorFitsner FeodorFitsner deleted the ndonkoHenri/v1-fix branch May 3, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants