Skip to content

Flutter extensions: flet_* packages moved to separate repositories #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 72 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
9c0fd67
Added deprecatation to Video control
FeodorFitsner Dec 5, 2024
e6ff9a9
Merge branch 'main' into feodor/flutter-extensions
FeodorFitsner Dec 6, 2024
dcf4b1c
Automatic registration of custom Flutter extensions
FeodorFitsner Dec 6, 2024
b190d0b
Add `flet` if no dependencies provided for `flet publish` command (#4…
FeodorFitsner Dec 10, 2024
12f2490
Update project_dependencies.py (#4459)
osamalzabidi Dec 3, 2024
be58db6
Fix PyInstaller hook to avoid download Flet app bundle on first run (…
FeodorFitsner Dec 12, 2024
3916011
Support `git`, `path`, `url` Poetry-style dependencies in pyproject.t…
FeodorFitsner Dec 12, 2024
717424a
Prepare Flet 0.25.2 (#4541)
FeodorFitsner Dec 13, 2024
963fac5
Merge branch 'main' into feodor/flutter-extensions
FeodorFitsner Jan 7, 2025
4f69d6e
flet_video removed and replaced with git dependency
FeodorFitsner Jan 7, 2025
e8ea26a
Merge branch '0.25.2' into feodor/flutter-extensions
FeodorFitsner Jan 7, 2025
df1409f
removed flet_audio
InesaFitsner Jan 7, 2025
2e34dbf
Install Flutter function
FeodorFitsner Oct 16, 2024
a7bfa88
Install JDK
FeodorFitsner Oct 18, 2024
1fcf8e3
Update poetry.lock
FeodorFitsner Jan 7, 2025
a7ee2ca
platform-specific dependencies in `tool.flet.{platform}.dependencies`
FeodorFitsner Jan 7, 2025
4830c5e
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
InesaFitsner Jan 7, 2025
50059ca
deleted flet_ads folder
InesaFitsner Jan 7, 2025
666905e
Fix __download_flet_client in dev mode
FeodorFitsner Jan 8, 2025
4343d08
deleted flet_audio_recorder folder
InesaFitsner Jan 8, 2025
54c9b87
Create android_sdk.py
FeodorFitsner Jan 8, 2025
47b42d9
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 8, 2025
7d1d3ed
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 8, 2025
50436a9
accept_sdkmanager_licenses
FeodorFitsner Jan 8, 2025
a6a2ef5
Fix temp dir
FeodorFitsner Jan 8, 2025
88bcd07
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 8, 2025
6ef65ba
removed flet_flashlight folder
InesaFitsner Jan 8, 2025
3566791
deleted flet_geolocator folder
InesaFitsner Jan 8, 2025
287643d
deleted flet_lottie
InesaFitsner Jan 8, 2025
e288b89
deleted flet_map
InesaFitsner Jan 8, 2025
6d64378
Update android_sdk.py
FeodorFitsner Jan 8, 2025
bcb8ea3
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 8, 2025
f5940b7
deleted flet_permissions_handler
InesaFitsner Jan 8, 2025
52f519b
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
InesaFitsner Jan 8, 2025
b7f3404
Merge branch 'main' into feodor/flutter-extensions
FeodorFitsner Jan 9, 2025
f6b7197
Fix deprecated imports
FeodorFitsner Jan 9, 2025
65bcc23
deleted flet_rive
InesaFitsner Jan 9, 2025
86b4b00
deleted flet_webview
InesaFitsner Jan 9, 2025
f42d358
Extract common utils
FeodorFitsner Jan 9, 2025
7f6ba45
Replace tqdm with Rich
FeodorFitsner Jan 9, 2025
b0ef43d
Replace print() with log()
FeodorFitsner Jan 9, 2025
f3b2008
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 9, 2025
66b7f1e
Package app first
FeodorFitsner Jan 9, 2025
0a931ab
Merge branch 'main' into feodor/flutter-extensions
FeodorFitsner Jan 10, 2025
2127aaa
Build command logging, styling, progresses
FeodorFitsner Jan 11, 2025
e0cdf41
Android SDK: cmdline-tools installation
FeodorFitsner Jan 13, 2025
69e386b
Install cmdlinetools
FeodorFitsner Jan 13, 2025
d46e570
Skip Android SDK installation if managed by Android Studio
FeodorFitsner Jan 13, 2025
87ac432
Cleanup
FeodorFitsner Jan 13, 2025
efd24e0
flutter-extension choice for create
InesaFitsner Jan 14, 2025
037a5c4
Nice way to install Android SDK packages
FeodorFitsner Jan 14, 2025
0f6ce9b
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 14, 2025
a49008e
"sep" for template
InesaFitsner Jan 14, 2025
cc2f9a9
fix badge bug
InesaFitsner Jan 14, 2025
7b4f8de
Fix process output
FeodorFitsner Jan 14, 2025
7d24508
Merge branch 'feodor/flutter-extensions' of https://github.com/flet-d…
FeodorFitsner Jan 14, 2025
5cd5d9c
Disable Flutter/Dart version check and analytics
FeodorFitsner Jan 14, 2025
590337c
All extensions are from git tags
FeodorFitsner Jan 15, 2025
c14a867
Flet desktop: load pre-build desktop client from build/{platform} dir
FeodorFitsner Jan 15, 2025
2ba4cd5
Change color theme to look nice in Ubuntu
FeodorFitsner Jan 15, 2025
2ae8518
Update poetry.lock
FeodorFitsner Jan 16, 2025
1e7614d
do not install virtualenv
FeodorFitsner Jan 16, 2025
6e6d1a6
do not install virtualenv in python tests
FeodorFitsner Jan 16, 2025
5a96035
Pin virtualenv==20.28.1
FeodorFitsner Jan 16, 2025
4fa2dc8
Add `flet=={version}` to requirements if no dependencies defined
FeodorFitsner Jan 16, 2025
06defc6
Install poetry into virtual environment
FeodorFitsner Jan 16, 2025
11498b0
add poetry to path
FeodorFitsner Jan 16, 2025
fd61604
Remove Python 3.8 tests
FeodorFitsner Jan 16, 2025
4bc3307
Fix Windows job
FeodorFitsner Jan 16, 2025
3b66261
Flutter 3.27.2, enable all CI jobs
FeodorFitsner Jan 16, 2025
93f358e
update template choices
InesaFitsner Jan 16, 2025
afc98ce
default template
InesaFitsner Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip Android SDK installation if managed by Android Studio
  • Loading branch information
FeodorFitsner committed Jan 13, 2025
commit d46e570f99389ed034d8830a85cbdfdf1a82ae2e
20 changes: 13 additions & 7 deletions sdk/python/packages/flet-cli/src/flet_cli/commands/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,6 @@ def initialize_build(self):
console.log("Dart executable:", self.dart_exe, style=verbose2_style)

if self.package_platform == "Android":
self.install_jdk()
self.install_android_sdk()

self.rel_out_dir = self.options.output_dir or os.path.join(
Expand Down Expand Up @@ -691,9 +690,20 @@ def install_jdk(self):
console.log(f"JDK installed {self.emojis['checkmark']}")

def install_android_sdk(self):
self.status.update(f"[bold blue]Installing Android SDK...")
from flet_cli.utils.android_sdk import AndroidSDK

android_home = AndroidSDK.android_home_dir()
if android_home and (android_home / "tools" / "bin").exists():
if self.verbose > 0:
console.log(
f"Android SDK is installed at {android_home} and managed by Android Studio",
style=verbose1_style,
)
return

self.install_jdk()

self.status.update(f"[bold blue]Installing Android SDK...")
self.env["ANDROID_HOME"] = AndroidSDK(
self.env["JAVA_HOME"], self.log_stdout, progress=self.progress
).install()
Expand Down Expand Up @@ -779,11 +789,7 @@ def setup_template_data(self):
self.flutter_dependencies = self.get_flutter_dependencies()
if self.verbose > 0:
console.log(
(
f"Additional Flutter dependencies: {self.flutter_dependencies}"
if len(self.flutter_dependencies) > 0
else "No additional Flutter dependencies!"
),
f"Custom Flutter dependencies: {self.flutter_dependencies}",
style=verbose1_style,
)

Expand Down
42 changes: 23 additions & 19 deletions sdk/python/packages/flet-cli/src/flet_cli/utils/android_sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,20 @@ def __init__(
self.log = log
self.progress = progress

def default_android_home_dir(self):
@staticmethod
def default_android_home_dir():
return (
Path.home() / "AppData" / "Local" / "Android" / "Sdk"
if platform.system() == "Windows"
else (
Path.home() / "Library" / "Android1" / "sdk"
Path.home() / "Library" / "Android" / "sdk"
if platform.system() == "Darwin"
else Path.home() / "Android" / "sdk"
)
)

def android_home_dir(self) -> Path | None:
@staticmethod
def android_home_dir() -> Path | None:
# check ANDROID_HOME environment variable
home_dir = os.getenv("ANDROID_HOME")
if home_dir and Path(home_dir).exists():
Expand All @@ -48,7 +50,7 @@ def android_home_dir(self) -> Path | None:
# check for Android SDKs installed with Android Studio
for hd in [
Path.home() / "Android" / "Sdk",
self.default_android_home_dir(),
AndroidSDK.default_android_home_dir(),
]:
if hd.exists():
return hd
Expand Down Expand Up @@ -99,7 +101,7 @@ def cmdline_tools_url(self):
)

def install(self):
home_dir = self.android_home_dir()
home_dir = AndroidSDK.android_home_dir()
install = True
if not home_dir:
home_dir = self.default_android_home_dir()
Expand All @@ -116,8 +118,8 @@ def install(self):

if install:
self._install_cmdlinetools(home_dir)

self._install_api_and_build_tools(home_dir)
self._install_api_and_build_tools(home_dir)
self._accept_licenses(home_dir)

return home_dir

Expand All @@ -144,11 +146,11 @@ def _install_api_and_build_tools(self, home_dir: Path):
p = self.run(
[
self.sdkmanager_exe(home_dir),
"cmdline-tools;latest",
"platform-tools",
f"platforms;android-{ANDROID_API_VERSION}",
f"build-tools;{BUILD_TOOLS_VERSION}",
],
env={"ANDROID_HOME": str(home_dir)},
input="y\n" * 10,
capture_output=False,
)
Expand All @@ -163,6 +165,7 @@ def _accept_licenses(self, home_dir: Path):
self.sdkmanager_exe(home_dir),
"--licenses",
],
env={"ANDROID_HOME": str(home_dir)},
input="y\n" * 20,
capture_output=False,
)
Expand All @@ -173,7 +176,9 @@ def _accept_licenses(self, home_dir: Path):
def get_installed_packages(self, home_dir: Path):
self.log("Checking installed Android APIs and build tools")
p = self.run(
[self.sdkmanager_exe(home_dir), "--list_installed"], capture_output=False
[self.sdkmanager_exe(home_dir), "--list_installed"],
env={"ANDROID_HOME": str(home_dir)},
capture_output=False,
)
if p.returncode != 0:
self.log(p.stderr)
Expand All @@ -182,23 +187,22 @@ def get_installed_packages(self, home_dir: Path):
)
return p.stdout

def run(self, args, cwd=None, input=None, capture_output=True):
def run(self, args, env=None, cwd=None, input=None, capture_output=True):

self.log(f"Run subprocess: {args}")

cmd_env = {"JAVA_HOME": self.java_home}

if env:
cmd_env = {**cmd_env, **env}

self.log(f"Process environment: {cmd_env}")

return processes.run(
args,
cwd if cwd else os.getcwd(),
env={"JAVA_HOME": self.java_home},
env=cmd_env,
input=input,
capture_output=capture_output,
log=self.log,
)


# Example usage
if __name__ == "__main__":
console = Console()
jdk_path = AndroidSDK(
os.environ["JAVA_HOME"], lambda m: console.log(m)
).accept_sdkmanager_licenses()
9 changes: 5 additions & 4 deletions sdk/python/packages/flet-cli/src/flet_cli/utils/processes.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@ def run(
env=cmd_env,
)

if input:
input_iterator = (
iter(input) if isinstance(input, list) else iter(input.split("\n"))
)
input_iterator = (
iter(input)
if isinstance(input, list)
else iter(input.split("\n")) if isinstance(input, str) else iter([])
)

try:
while True:
Expand Down