Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put it the right version of flet #1997

Closed
wants to merge 5 commits into from
Closed

Conversation

AdamMusa
Copy link

@AdamMusa AdamMusa commented Oct 27, 2023

I followed the contribution guide correctly and I tried to run a small application by running the command poetry install then poetry run python hello.py I came across this error. we assume I have a file with this content

import flet
from flet import Page, Text

def main(page: Page):
    page.add(Text("Hello, world!"))

flet.app(target=main)

after this command poetry run python hello.py here is the error

error

I found the error is on this line of file flet/src/version.py
version = "0.2.0" and this version does not exist yet in https://github.com/flet-dev/flet/releases/
so I hard coded with one exist version if all the condition not respecte and everything work correctly

result

@FeodorFitsner
Copy link
Contributor

Did you install Flet with pip or just cloned the repo?
Did you clone repo with git clone or downloaded as zip? Do you have a localized version of Git?

@AdamMusa
Copy link
Author

Did you install Flet with pip or just cloned the repo? Did you clone repo with git clone or downloaded as zip? Do you have a localized version of Git?

I cloned the repo with git clone .

@FeodorFitsner
Copy link
Contributor

OK, what output do you get by running git status while in repo's directory?

@AdamMusa
Copy link
Author

AdamMusa commented Oct 31, 2023

OK, what output do you get by running git status while in repo's directory?

On both branches(my branch and main branch) I got the same output

"On the hand branch
Your branch is up to date with 'origin/main' or 'origin/fix_version'.

nothing to validate, the working copy is clean"

@FeodorFitsner
Copy link
Contributor

I guess this line is the culprit:

).stdout.startswith("On branch ")

@AdamMusa
Copy link
Author

I guess this line is the culprit:

Yeah

@FeodorFitsner
Copy link
Contributor

But why "On the hand branch" in your case? Could you post a screenshot please? What version of git is that?

@AdamMusa
Copy link
Author

AdamMusa commented Oct 31, 2023

But why "On the hand branch" in your case? Could you post a screenshot please? What version of git is that?

Oh it was my fault it would be in "On main branch"

My system is in french
Here is the screenshots of my branch and main branch

main fix

@AdamMusa
Copy link
Author

AdamMusa commented Nov 7, 2023

I have not provided more necessary information?

@FeodorFitsner
Copy link
Contributor

I fixed it here, differently: 091c915

@AdamMusa
Copy link
Author

AdamMusa commented Nov 7, 2023

I noticed that you add code only for windows I hope it going to work on Mac . Because the bug I occured and fixed is about Mac

@FeodorFitsner
Copy link
Contributor

It's a fix for all platforms. You can give a try with preview version of Flet.

zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
* AlertDialog uses global state

* DatePicker uses global state

* State on the control level

* Control-level state

Fix flet-dev#2025, Fix flet-dev#1807, Fix flet-dev#1236, Fix flet-dev#1772

* Fix control tests

* Bump fl_chart to 0.64.0

* Fix `scroll_to` with 0 animation duration

Fix flet-dev#1659

* Fix page.width/.height on session start

Fix flet-dev#1960

* Fix Flet version retrieval on non-English environments

Fix flet-dev#1997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants