Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create initial value for __theme_mode attribute in Page class. #1321

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Create initial value for __theme_mode attribute in Page class. #1321

merged 1 commit into from
Apr 23, 2023

Conversation

thearyadev
Copy link
Contributor

This change resolves #1153 by initializing self.__theme_mode in the __init__ method of the Page class to avoid the AttributeError raised by the theme_mode property method on line 1205.

I've set this attribute to ThemeMode.SYSTEM as noted in the documentation for the default value of page.theme_mode

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@FeodorFitsner FeodorFitsner merged commit 4b4dc11 into flet-dev:main Apr 23, 2023
zrr1999 pushed a commit to zrr1999/flet that referenced this pull request Jul 17, 2024
@thearyadev @zrr1999
Create initial value for __theme_mode attribute in Page class. (flet-…
7b61ca6 
…dev#1321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading page.theme_mode fails if never set before
3 participants
@thearyadev @CLAassistant @FeodorFitsner