Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Theming Switch and Checkbox component #523

Closed
Skquark opened this issue Oct 26, 2022 · 6 comments
Closed

Feature: Theming Switch and Checkbox component #523

Skquark opened this issue Oct 26, 2022 · 6 comments
Milestone

Comments

@Skquark
Copy link

Skquark commented Oct 26, 2022

So all the components that I'm using are being color themed automatically, except for Switch and Checkbox.. At least Checkbox I can manually give it the check_color and fill_color to the color theme, however it doesn't look like Switch has any color setting options exposed. I expected it to have active_color, active_track_color, inactive_thumb_color, and inactive_track_color, but it doesn't look like that's been implemented yet. Ideally they would default to the accent color of the theme like all the other components, but if not I'd like to manually set it. Thanks...

@FeodorFitsner FeodorFitsner added this to the Controls-S3 milestone Oct 26, 2022
@Skquark
Copy link
Author

Skquark commented Nov 2, 2022

Another thing I've noticed using the Switch & Checkbox is that the tooltip text parameter doesn't work on the Switch but it does on Checkbox. However the tooltip on the Checkbox pops up in the center, offset from the checkbox that's aligned on the left, so it looks strange detached in the middle. Tried to hack it to align right, like it does correctly on the button tooltips, but couldn't find a workaround without getting into the Flet code.

@ndonkoHenri
Copy link
Collaborator

It will be great to have a Tooltip class.

#367

@FeodorFitsner
Copy link
Contributor

Working on #367!

@FeodorFitsner
Copy link
Contributor

@Skquark Regarding tooltip location: it's shown in the middle because checkbox with a label consists of Checkbox widget and Text put in a Row widget together and the resulting group has a tooltip over it. If you need to show tooltip when hovering Checkbox then do not use built-in "label".

@FeodorFitsner FeodorFitsner added the status: working on it Working on a fix for the issue label Nov 3, 2022
FeodorFitsner added a commit that referenced this issue Nov 3, 2022
@FeodorFitsner FeodorFitsner removed the status: working on it Working on a fix for the issue label Nov 10, 2022
@Skquark
Copy link
Author

Skquark commented Nov 11, 2022

Looking forward to seeing the change merged, I tried installing the git controls-s3 branch in my project but it didn't install right for some reason. Also noticed you were adding a ResponsiveRow control, which is totally what I needed to fix my UI flaws when shrinking the width, tried with wrap=True or with the GridView, but wasn't behaving the way I wanted to be responsive. Would also love to see the Tooltip class, almost all of my Switches with labels could also use a tooltip to provide more information about what the switch does that I can't fit in the label.
Thanks a bunch, been having a lot of fun coding with this framework...

@FeodorFitsner
Copy link
Contributor

It's been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants