Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flet build should raise an error when trying to package an app with native modules for iOS or Android #2356

Closed
FeodorFitsner opened this issue Jan 9, 2024 · 11 comments
Closed

flet build should raise an error when trying to package an app with native modules for iOS or Android #2356

FeodorFitsner opened this issue Jan 9, 2024 · 11 comments
Assignees
@FeodorFitsner
Labels
enhancement Improvement/Optimization packaging Related to app packaging

Comments

@FeodorFitsner
Copy link
Contributor

Related case: #2332 (comment)
@FeodorFitsner FeodorFitsner added the enhancement Improvement/Optimization label Jan 9, 2024
@FeodorFitsner FeodorFitsner self-assigned this Jan 9, 2024
@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

@FeodorFitsner I have a question, not related to the issue. Can we include stackoverflow code here in this repository?

@FeodorFitsner
Copy link
Contributor Author

What do you mean?

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

I mean, that can we use the code from stackoverflow questions and answers in the commits to this repo?

@FeodorFitsner
Copy link
Contributor Author

Sure, we can: https://stackoverflow.com/help/licensing provided attribution to the original source/author is kept, like a link to a SO article should work I guess.

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

Okay then, thank you

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

And @FeodorFitsner , please provide me an insight of how do you provide warnings to the user in the flet cli?

@FeodorFitsner
Copy link
Contributor Author

For example?

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

Like, if we wanted to provide warning to the user about the C extension modules...

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

And can we use python's built in warnings.warn function?

@FeodorFitsner
Copy link
Contributor Author

Sure, we can. Here is an example: https://github.com/flet-dev/flet/blob/main/sdk/python/packages/flet-core/src/flet_core/text.py#L275-L279

@taaaf11
Copy link
Contributor

taaaf11 commented Jan 10, 2024

Thank you 😊

@FeodorFitsner FeodorFitsner added the packaging Related to app packaging label Jan 10, 2024
FeodorFitsner added a commit that referenced this issue Jan 14, 2024
@FeodorFitsner
flet build should raise an error when trying to package an app with…
4e824a5 
… native modules for iOS or Android

Close #2356
zrr1999 pushed a commit to zrr1999/flet that referenced this issue Jul 17, 2024
@FeodorFitsner @zrr1999
flet build improvements (flet-dev#2404)
45996fa 
* `flet build -vv` should run `pip install` with verbose output

Close flet-dev#2351

* `flet build` should raise an error when trying to package an app with native modules for iOS or Android

Close flet-dev#2356

* Generate app asset hash for more effective unpacking

Close flet-dev#2289

* Fix "OSError: [WinError 193] %1 is not a valid Win32 application" error on Windows

Fix flet-dev#2318

* Flet version bumped to 0.19.0

* Replace --windows-tcp-port with a random port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FeodorFitsner FeodorFitsner

Labels
enhancement Improvement/Optimization packaging Related to app packaging
Projects
Flet Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FeodorFitsner @taaaf11