Assignment 4 #31
Open
Assignment 4 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution is based on the concept described here: https://en.wikipedia.org/wiki/Disjoint-set_data_structure In this solution, a subset is initially just a patch of land and their union (or one patch of land by itself) is an island.
kulizhsy
approved these changes
Jul 10, 2018
Collaborator
kulizhsy
left a comment
kulizhsy
left a comment
There was a problem hiding this comment.
Great job and on such a short notice!
| if (j > 0 && map[i][j - 1] && | ||
| (i == 0 || !map[i - 1][j] || | ||
| find((i - 1) * map.size() + j, parent) != | ||
| find(i * map.size() + (j - 1), parent))) { |
Collaborator
There was a problem hiding this comment.
This if statement is very hard to parse mentally. Prefer to hide 'ugly' code like that behind helper functions:
if (j > 0 && map[i][j - 1] && AnotherCheck(...)) { ..}
Whoever needs to read this in 5 months time will thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is based on the concept described here:
https://en.wikipedia.org/wiki/Disjoint-set_data_structure
In this solution, a subset is initially just a patch of land and their union (or one patch of land by itself) is an island.