Skip to content

Conversation

@flemzord
Copy link
Owner

@flemzord flemzord commented Sep 17, 2025

  • Included detailed steps for creating a new compliance check class, registering it, defining configuration types, updating the JSON schema, and adding tests.
  • Enhanced documentation to facilitate the onboarding of new contributors and improve project extensibility.

Summary by cubic

Added step-by-step instructions to the README for adding a new compliance check to make contributor onboarding faster.
Covers creating the check class, registering it, defining config types, updating the JSON Schema, adding tests, and updating the Available Checks and sample YAML.

- Included detailed steps for creating a new compliance check class, registering it, defining configuration types, updating the JSON schema, and adding tests.
- Enhanced documentation to facilitate the onboarding of new contributors and improve project extensibility.
@github-actions github-actions bot added documentation Improvements or additions to documentation source size/S labels Sep 17, 2025
@github-actions
Copy link

📊 Build Report

Bundle Size: 1.15 KB
Node Versions Tested: 18, 20, 22
All Checks: ✅ Passed

Details
  • Linting (BiomeJS, Knip, TypeScript): ✅
  • Tests with coverage: ✅
  • Build: ✅
  • Integration test: ✅

Generated for commit f6a6a90

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 1 file

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="README.md">

<violation number="1" location="README.md:302">
Incorrect type name in docs: use Defaults (not ComplianceDefaults) to match src/config/types.ts and ComplianceConfig.defaults.</violation>

<violation number="2" location="README.md:308">
Clarify JSON Schema update: also add the new key under rules.apply properties, not just defaults, since additionalProperties is false in both sections.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

}
```

4. **Update the JSON Schema** in `compliance-schema.json`:
Copy link

@cubic-dev-ai cubic-dev-ai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify JSON Schema update: also add the new key under rules.apply properties, not just defaults, since additionalProperties is false in both sections.

Prompt for AI agents
Address the following comment on README.md at line 308:

<comment>Clarify JSON Schema update: also add the new key under rules.apply properties, not just defaults, since additionalProperties is false in both sections.</comment>

<file context>
@@ -239,6 +239,99 @@ npm run build
+   }
+   ```
+
+4. **Update the JSON Schema** in `compliance-schema.json`:
+   - Add your check configuration to the `defaults` properties
+   - Ensure proper validation rules are defined
</file context>
Fix with Cubic

// Define your configuration structure
}

export interface ComplianceDefaults {
Copy link

@cubic-dev-ai cubic-dev-ai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect type name in docs: use Defaults (not ComplianceDefaults) to match src/config/types.ts and ComplianceConfig.defaults.

Prompt for AI agents
Address the following comment on README.md at line 302:

<comment>Incorrect type name in docs: use Defaults (not ComplianceDefaults) to match src/config/types.ts and ComplianceConfig.defaults.</comment>

<file context>
@@ -239,6 +239,99 @@ npm run build
+     // Define your configuration structure
+   }
+
+   export interface ComplianceDefaults {
+     // ... existing configs
+     your_config_key?: YourCheckConfig;
</file context>
Suggested change
export interface ComplianceDefaults {
export interface Defaults {
Fix with Cubic

@flemzord flemzord merged commit e9ee43d into main Sep 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/S source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant