Reduce complexity of Pending and PendingTracker and Caller#339
Merged
Reduce complexity of Pending and PendingTracker and Caller#339
Conversation
added 3 commits
February 24, 2026 19:06
fleming79
added
enhancement
added 4 commits
February 25, 2026 09:55
- Added PendingManager.remove. - Change order of trackers, context to context, trackers in Pending. - Removed add_to_trackers method.
fleming79
force-pushed
the
enhancement
branch
from
aa20418 to
dfa8df4
Compare
fleming79
changed the title
added 6 commits
February 25, 2026 10:16
fleming79
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some low-level functionality on Pending and Caller.queue_call. Although the features worked, they introduced complexity in maintenance.
Changes
resetargument fromPending.set_result_forcekeyword argument fromPending.cancelCaller.queue_callno longer returns a pending and the pending that is created is only tracked by PendingManager (not PendingGroup).queue_callshould be regarded as a low-level like 'call_direct'.Pending.add_to_trackersmethod