Skip to content

Refactor Caller.wait to avoid catching exceptions. #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fleming79 merged 1 commit into from
Sep 6, 2025
Merged

Refactor Caller.wait to avoid catching exceptions. #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/async_kernel/caller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,23 +132,22 @@ async def wait(self, *, timeout: float | None = None, shield: bool = False, resu

Args:
timeout: Timeout in seconds.
shield: Shield cancellation.
shield: Shield the future from cancellation.
result: Whether the result should be returned.
"""
if not self._event_done.is_set():
with anyio.fail_after(delay=timeout):
try:
try:
if not self.done():
with anyio.fail_after(timeout):
if threading.current_thread() is self.thread:
if not self._anyio_event_done:
self._anyio_event_done = anyio.Event()
await self._anyio_event_done.wait()
else:
await wait_thread_event(self._event_done)
except BaseException as e:
if not shield:
self.cancel(str(e))
raise
return self.result() if result else None
return self.result() if result else None
finally:
if not self.done() and not shield:
self.cancel("Cancelled with waiter cancellation.")

if TYPE_CHECKING:

Expand Down
Loading