Add 'type="button"' to prevent form submission #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnysteen Can you confirm that this change fixes the problem for you? In my tests, the fix worked and it seem to be good practice to set the button type in general. |
|
Yes, this seems to fix it - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
See #83
Currently Observed Behavior
When
<Modal />is wrapped by a<form />, clicking on the default close button submits the formDemo: https://svelte.dev/repl/dd87925ed7a64f08936257414fd63841?version=3.48.0
New Behavior
With the change, the close button has not default behavior and, thus, will not submit the form
Demo: https://svelte.dev/repl/7e3efb8138314975ad246a3a575a450b?version=3.48.0