Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove JupyterScatter.hovering_widget #117

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

manzt
Copy link
Collaborator

@manzt manzt commented Apr 2, 2024

Write one to two sentences summarizing this PR

Removes JupyterScatter.hovering_widget. The JupyterScatter.hovered_point
property is not defined anywhere on the widget. I believe this traitlet was
likely added at some time but was removed, and this bug hasn't popped up due to
lack of accessing this field from others.

A recent release of anywidget inspects the fields on the widget class within
__init__, which invokes the @property decorator on the hovering_widget.
This led to an attribute error.

Description

What was changed in this pull request?

Why is it necessary?

Fixes #115

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in API.md/README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for calm-platypus-50e85d canceled.

Name Link
🔨 Latest commit 6ca766e
🔍 Latest deploy log https://app.netlify.com/sites/calm-platypus-50e85d/deploys/660c6a2f6a2b770009b0d483

@flekschas flekschas self-requested a review April 2, 2024 21:11
@flekschas flekschas merged commit 0a258aa into main Apr 2, 2024
4 checks passed
@flekschas flekschas deleted the manzt/remove-hovered_point branch April 2, 2024 21:12
flekschas added a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'JupyterScatter' object has no attribute 'hovered_point'
2 participants