Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Remove wrap from disk encryption status, table scroll horiz #25017

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Dec 26, 2024

Issue

Cerra confidential 8903

Description

  • Per product update to spec, instead of wrapping the text or truncating with a tooltip, allow horizontal scroll on the disk encryption status table

Screenrecording of new solution

Screen.Recording.2024-12-26.at.12.03.32.PM.mov

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested a review from a team as a code owner December 26, 2024 16:40
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (ec43ee2) to head (5ea54e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25017   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files        1610     1610           
  Lines      153230   153230           
  Branches     4012     4012           
=======================================
  Hits        97743    97743           
  Misses      47694    47694           
  Partials     7793     7793           
Flag Coverage Δ
frontend 53.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.linkToFilteredHosts__cell {
width: auto;
max-width: 120px;
padding-left: 0 !important; // Removes 24px of unnecessary table scroll
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 24px padding left of the filtered host link arrow because it's a lot of dead space between the last column (linux hosts) and the arrow causing unnecessary scroll

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's another way without using !important, that would be better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can ask @eugkuo how he feels about removing left padding on that link all together, the column left of it already has right padding so I feel like double padding is just asking for unnecessary white space scroll

Copy link
Member Author

@RachelElysia RachelElysia Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr: I removed the left padding to the view all host link so the user is less likely to need to scroll over to view it. I had to use !important which is ill-advised in frontend land to get it to apply without updating the component itself

@eugkuo lmkwyt about the double padding. If we can remove it globally, I can remove !important

here's a before picture: #25017 (comment)

@RachelElysia RachelElysia merged commit e94aa2d into main Dec 26, 2024
11 checks passed
@RachelElysia RachelElysia deleted the 8903-revision branch December 26, 2024 18:47
@RachelElysia
Copy link
Member Author

RachelElysia commented Dec 26, 2024

Before padding (which causes so much extra white space to scroll horizontally through):
Screenshot 2024-12-26 at 2 47 36 PM
Screenshot 2024-12-26 at 2 47 44 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants