update UI errors for secrets on scripts and software #25008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25008 +/- ##
=======================================
Coverage 63.75% 63.75%
=======================================
Files 1610 1610
Lines 153174 153166 -8
Branches 3928 3923 -5
=======================================
- Hits 97660 97658 -2
+ Misses 47728 47722 -6
Partials 7786 7786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
approved these changes
Dec 24, 2024
| } else { | ||
| renderFlash("error", getErrorMessage(e)); | ||
| } | ||
| renderFlash("error", getErrorMessage(e)); |
| "error", | ||
| `Couldn’t upload. Request timeout. Please make sure your server and load balancer timeout is long enough.` | ||
| ); | ||
| } else if (reason.includes("Fleet couldn't read the version from")) { |
There was a problem hiding this comment.
Is there a reason this else if was removed? I added it back, but lmk
There was a problem hiding this comment.
I think I mistakenly deleted this. Thanks for catching
There was a problem hiding this comment.
@ghernandez345 thanks for cleaning up the error code!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #24550
This addes some UI error messages when trying to use fleet secret variables on scripts and software packages.