Fix uninstall for Warp and Box

[dantecatalfamo]

#22773

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• Manual QA for all new/changed functionality

[dantecatalfamo]

The box uninstaller still misses one step that's required as part of the uninstall process listed on the box website due to it needing an interactive terminal, but it won't fail spectacularly like it did before

[mna]

Couple comments / questions but overall LGTM.

[mna]

That's so that an explicit sudo is not required to run the uninstall_box_drive_r binary? We can't do the explicit sudo in the uninstall script itself?

[dantecatalfamo]

That's done because there's a sudo in the /Library/Application Support/Box/uninstall_box_drive script that the brew artifact runs. The problem is that without that line sudo fails because the user can't be asked for a password.

Here's an excerpt from the script:

if [ 0 -eq "$user_level_uninstall" ]; then
    # Do the work that requires sudo - this work is placed in a separate script to support
    # developers. On Jenkins passwordless sudo is enabled. But on developer machines we
    # shouldn't require a blanket password-less sudo. This is an issue because developers
    # run Chimp locally and Chimp executes these uninstall scripts and it's often the case
    # that there's no STDIN for sudo to use to get the password. Thus, by placing all the
    # logic that requires sudo in a script called uninstall_box_drive_r... the developers
    # can add an password-exemption for just that script in /etc/sudoers that looks like:
    #     <username> ALL = (root) NOPASSWD: /Library/Application\ Support/Box/uninstall_box_drive_r
    #
    sudo "${0%/*}/"uninstall_box_drive_r $fuse_failure_quits $delete_logs
fi

[dantecatalfamo]

It passes in some arguments from the main uninstall script. In the _r script, it asks that you don't call it independently

[mna]

Gotcha, thanks!

[dantecatalfamo]

We should probably have a function that does this as part of our other toolbox, calling sudo -u $user from /root will make the shell freak out