Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API design] Create policies automatically for Fleet-maintained apps #22609

Closed
wants to merge 16 commits into from
Closed

[API design] Create policies automatically for Fleet-maintained apps #22609

wants to merge 16 commits into from

Conversation

marko-lisica
Copy link
Member

@marko-lisica marko-lisica commented Oct 3, 2024 •
edited
Loading

API design for: #22077

@marko-lisica Closing this PR and replacing with new one that's branched off of docs-v4.60.0.

@marko-lisica marko-lisica mentioned this pull request Oct 3, 2024
Closed
67 tasks
marko-lisica
marko-lisica commented Oct 3, 2024
View reviewed changes
docs/REST API/rest-api.md Outdated
@@ -9108,10 +9110,12 @@ Returns information about the specified software. By default, `versions` are sor
"uploaded_at": "2024-04-01T14:22:58Z",
"install_script": "sudo installer -pkg '$INSTALLER_PATH' -target /",
"pre_install_query": "SELECT 1 FROM macos_profiles WHERE uuid='c9f4f0d5-8426-4eb8-b61b-27c543c9d3db';",
"automatic_install_query": "SELECT 1 FROM apps WHERE name='Falcon.app';",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note

This is new.

marko-lisica
marko-lisica commented Oct 3, 2024
View reviewed changes
docs/REST API/rest-api.md Outdated
Comment on lines 9117 to 9118
"install_method": "automatic",
"fleet_maintained": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note:

These are new.

@marko-lisica marko-lisica marked this pull request as draft October 3, 2024 16:17
@noahtalerman
Copy link
Member

Hey @marko-lisica just checking, is there a reason this PR is still in draft mode? If it's ready for review from @rachaelshaw, we want it to be in "Ready for review" mode so that Rachael can merge it into the reference docs branch when it's good to go.

@marko-lisica
Copy link
Member Author

@noahtalerman I'm waiting for this one (#22769) to be merged. After that, I can remove things that are merged from this PR before merging them into docs for 4.59. Otherwise, I will need to create a new PR to delete things that are already in main or we'll need to resolve a bunch of conflicts.

@noahtalerman
Copy link
Member

I'm waiting for this one (#22769) to be merged. After that, I can remove things that are merged from this PR before merging them into docs for 4.59. Otherwise, I will need to create a new PR to delete things that are already in main or we'll need to resolve a bunch of conflicts.

Ah! That's right. Sorry I forgot we talked about that.

georgekarrv
georgekarrv reviewed Oct 23, 2024
View reviewed changes
docs/REST API/rest-api.md Outdated
@@ -8881,7 +8881,7 @@ Get a list of all software.
"software_package": {
"name": "FirefoxInsall.pkg",
"version": "125.6",
"self_service": true
"self_service": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the final item in an object typically doesn't have the trailing comma. It was more correct before.

@marko-lisica marko-lisica changed the title [API design] Fleet-maintained apps: automatic install [API design] Create policies automatically for Fleet-maintained apps Nov 5, 2024
marko-lisica
marko-lisica commented Nov 6, 2024
View reviewed changes
docs/REST API/rest-api.md Show resolved Hide resolved
docs/REST API/rest-api.md Show resolved Hide resolved
docs/REST API/rest-api.md Show resolved Hide resolved
docs/REST API/rest-api.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getvictor getvictor getvictor left review comments

@georgekarrv georgekarrv georgekarrv left review comments

@rachaelshaw rachaelshaw rachaelshaw approved these changes

@lukeheath lukeheath Awaiting requested review from lukeheath

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marko-lisica @noahtalerman @georgekarrv @getvictor @rachaelshaw