Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Custom settings pagination does not work #23404

Closed
jb2barrels opened this issue Oct 30, 2024 · 9 comments
Closed

[Bug] Custom settings pagination does not work #23404

jb2barrels opened this issue Oct 30, 2024 · 9 comments
Assignees
@jahzielv
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.61.0

Comments

@jb2barrels
Copy link

Fleet version: Latest v4.58.0

Web browser and operating system: Google Chrome tested on both Linux and MacOS.

💥  Actual behavior

Clicking 'Next >' always returns back to page 0:
/controls/os-settings/custom-settings?page=0

Manually modifying the URL to ?page=1 works as intended.

🧑‍💻  Steps to reproduce

  1. Visit Controls > OS settings > Custom settings
  2. Add lots of mobileconfig profiles, so you have multiple pages.
  3. Attempt to paginate to the next page.
  4. Page will only stay at index 0
@jb2barrels jb2barrels added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented labels Oct 30, 2024
@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. #g-endpoint-ops Endpoint ops product group labels Oct 30, 2024
@lukeheath
Copy link
Member

@jb2barrels Thanks for letting us know. We'll take a look and get it corrected in an upcoming release.

@RachelElysia
Copy link
Member

@xpkoala This is 2 weeks old and I think this is a higher priority bug if this is the case. Can you reproduce?

@xpkoala
Copy link
Contributor

xpkoala commented Nov 15, 2024

Sorry for the delay on this. This looks to be fixed in 4.59.0.

@jb2barrels could you try updating to the latest release, 4.59.0, and letting us know if the behavior is persisting on your end?

@jb2barrels
Copy link
Author

jb2barrels commented Nov 15, 2024 •
edited
Loading

@xpkoala
Running v4.59.0 , issue persists.
Please note this is also the self-hosted free version incase that affects testing on your end.

( GIF below depicts showing me click the next page button, and it loads the same page = 0. If i manually switch to page 1, then click next page it'll go back to page zero )
pagination-issue
image

@xpkoala
Copy link
Contributor

xpkoala commented Nov 15, 2024

@jb2barrels thank you for the update. I'll take a deeper dive in just a moment and let you know what I find.

@xpkoala
Copy link
Contributor

xpkoala commented Nov 15, 2024

Thank you again @jb2barrels, I was able to reproduce this on the free version of Fleet. It looks we are making a call to the correct page but also a second call back to page 0.

We'll get this looked at and hopefully fixed in the next minor release.

Quick demo of the behavior for eng:

Screen.Recording.2024-11-15.at.12.43.06.PM.mov

@xpkoala xpkoala added ~frontend Frontend-related issue. ~released bug This bug was found in a stable release. and removed :reproduce Involves documenting reproduction steps in the issue labels Nov 15, 2024
@RachelElysia RachelElysia added #g-mdm MDM product group and removed #g-endpoint-ops Endpoint ops product group labels Nov 15, 2024
@georgekarrv georgekarrv added this to the 4.61.0-tentative milestone Nov 21, 2024
@jahzielv jahzielv self-assigned this Dec 6, 2024
@jahzielv jahzielv mentioned this issue Dec 6, 2024
Merged
2 tasks
jahzielv added a commit that referenced this issue Dec 6, 2024
@jahzielv
fix: do pagination in fleet free with correct query params (#24494)
216743b 
> Related issue: #23404

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
jahzielv added a commit that referenced this issue Dec 9, 2024
@jahzielv
fix: do pagination in fleet free with correct query params (#24494)
da95c83 
> Related issue: #23404

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
@jahzielv
Copy link
Contributor

jahzielv commented Dec 9, 2024

Note for QA: this issue was also happening for scripts on Fleet free. The fix addresses both the profiles and the scripts.

@PezHub
Copy link
Contributor

PezHub commented Dec 9, 2024

QA notes:

confirmed the pagination bug in the scripts and profiles page for our free version, but after applying the fix I was able to navigate successfully thru the different pages using the Next > and < Previous buttons. QA Approved!

@fleet-release
Copy link
Contributor

Pagination bug fixes,
Fleet's flow smooth as river's course,
Settings sail with ease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jahzielv jahzielv

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.61.0
Development

No branches or pull requests
9 participants
@georgekarrv @lukeheath @xpkoala @jahzielv @RachelElysia @fleet-release @sharon-fdm @jb2barrels @PezHub