-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show software details on "My device" page #23315
Comments
Please add your planning poker estimate with Zenhub @jacobshandling |
## #23315 - On device user page > Software, make rows clickable and on click, open the Software details modal to display information about the installation on the host. - Update Software details modal copy and allow long file paths to wrap https://github.com/user-attachments/assets/1e714c5e-1614-46c0-bb56-d6dc8ad4f8ae <img width="1350" alt="Screenshot 2024-12-26 at 10 27 44 AM" src="https://github.com/user-attachments/assets/5cefc45a-b0ef-41d9-84e6-21ac17aaeffe" /> <img width="1350" alt="Screenshot 2024-12-26 at 10 27 19 AM" src="https://github.com/user-attachments/assets/e0866961-31a4-4bd3-82e8-18f72cf4dc30" /> <img width="1350" alt="Screenshot 2024-12-26 at 10 27 37 AM" src="https://github.com/user-attachments/assets/2bf6c880-664d-4315-8a40-8de61a5e4748" /> - [x] Changes file added for user-visible changes in `changes/`, - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@jacobshandling there wasn't a test plan on this one so I added some steps. Can you confirm that the test plan appropriately covers the changes that were made? The reason I am asking is because on Ubuntu, I don't ever see anything other than Version and Type. On Mac and Windows, sometimes Last used is there and sometimes it's not. Very occasionally, there won't be a File path. And sometimes there is an "Install details" tab in the modal that doesn't seem to work. |
Great catches @jmwatts, thank you. To document what we discussed: I've hidden the "Install details" tab on the My device page for now (see PR for details on reasoning and next steps). Regarding varying information being returned and displayed, the UI is displaying whatever data it gets from the API. Whether or not the API is returning data as expected in various cases (Filepath, last used, etc.) is a question for product, so we're adding to the design review agenda. If it's working as expected, we're good, and if not, we can either call it a bug or a feature request and have that implemented on the next iteration. |
Goal
Objective
None. Fleet prioritizes small UX improvements based on user feedback.
Original requests
#23252
Context
Changes
Product
Engineering
QA
Risk assessment
Manual testing steps
On My device page for Mac, Linux, Windows hosts:
Testing notes
Confirmation
The text was updated successfully, but these errors were encountered: