Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show software details on "My device" page #23315

Open
12 of 22 tasks
rachaelshaw opened this issue Oct 28, 2024 · 3 comments
Open
12 of 22 tasks

Show software details on "My device" page #23315

rachaelshaw opened this issue Oct 28, 2024 · 3 comments
Assignees
Labels
~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group #g-software Software product group ~pushed User story was pushed to next release. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature

Comments

@rachaelshaw
Copy link
Member

rachaelshaw commented Oct 28, 2024

Goal

User story
As an end user on the "My device" page,
I want to see file paths of installed software
so that I can see where I have vulnerable software installed.

Objective

None. Fleet prioritizes small UX improvements based on user feedback.

Original requests

#23252

Context

Changes

Product

  • UI changes: Figma
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: No changes
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: No changes
  • Other reference documentation changes: No changes
  • Once shipped, requester has been notified

Engineering

  • Feature guide changes: No changes
  • Database schema migrations: No changes
  • Load testing: No changes
  • Specification: Implement per Figma above (Add details to the software page).
  • Test-plan - To be created by the DRI engineer and approved by QA person

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: No
  • Risk level: Low / High Low
  • Risk description: UI changes with low risk

Manual testing steps

On My device page for Mac, Linux, Windows hosts:

  • Verify "show details" link appears on hover and when clicked, brings you to the details modal for the software
  • Verify "show details" link appears tabbed focus of a row and when pressing enter, brings you to the details modal for the software
  • Verify Version, Type, Last used, File path, and Vulnerabilities are shown
  • Verify for different types of software
  • Verify on Chrome, Safari, Firefox (where applicable)

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@rachaelshaw rachaelshaw added story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group labels Oct 28, 2024
@rachaelshaw rachaelshaw self-assigned this Oct 28, 2024
@rachaelshaw rachaelshaw changed the title Show software file paths on "My device" page Show software details on "My device" page Nov 4, 2024
@rachaelshaw rachaelshaw assigned sharon-fdm and unassigned rachaelshaw Nov 4, 2024
@sharon-fdm sharon-fdm added the ~frontend Frontend-related issue. label Nov 4, 2024
@RachelElysia
Copy link
Member

Please add your planning poker estimate with Zenhub @jacobshandling

@sharon-fdm sharon-fdm removed their assignment Nov 6, 2024
@noahtalerman noahtalerman added Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. :product Product Design department (shows up on 🦢 Drafting board) labels Nov 11, 2024
@sharon-fdm sharon-fdm added this to the 4.61.0-tentative milestone Nov 18, 2024
@sharon-fdm sharon-fdm added the ~pushed User story was pushed to next release. label Dec 6, 2024
@sharon-fdm sharon-fdm modified the milestones: 4.61.0, 4.61.0-tentative Dec 9, 2024
@lukeheath lukeheath modified the milestones: 4.61.0-tentative, 4.61.0 Dec 11, 2024
@lukeheath lukeheath added the #g-software Software product group label Dec 19, 2024
jacobshandling added a commit that referenced this issue Dec 26, 2024
## #23315 

- On device user page > Software, make rows clickable and on click, open
the Software details modal to display information about the installation
on the host.
- Update Software details modal copy and allow long file paths to wrap


https://github.com/user-attachments/assets/1e714c5e-1614-46c0-bb56-d6dc8ad4f8ae

<img width="1350" alt="Screenshot 2024-12-26 at 10 27 44 AM"
src="https://github.com/user-attachments/assets/5cefc45a-b0ef-41d9-84e6-21ac17aaeffe"
/>
<img width="1350" alt="Screenshot 2024-12-26 at 10 27 19 AM"
src="https://github.com/user-attachments/assets/e0866961-31a4-4bd3-82e8-18f72cf4dc30"
/>
<img width="1350" alt="Screenshot 2024-12-26 at 10 27 37 AM"
src="https://github.com/user-attachments/assets/2bf6c880-664d-4315-8a40-8de61a5e4748"
/>


- [x] Changes file added for user-visible changes in `changes/`, 
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@jmwatts
Copy link
Member

jmwatts commented Dec 27, 2024

@jacobshandling there wasn't a test plan on this one so I added some steps. Can you confirm that the test plan appropriately covers the changes that were made?
Should I see Version, Type, Last used, File path, and Vulnerabilities on every details modal or will there be scenarios where those won't appear?

The reason I am asking is because on Ubuntu, I don't ever see anything other than Version and Type. On Mac and Windows, sometimes Last used is there and sometimes it's not. Very occasionally, there won't be a File path. And sometimes there is an "Install details" tab in the modal that doesn't seem to work.
Screenshot 2024-12-27 at 9 15 27 AM
Screenshot 2024-12-27 at 9 28 44 AM

@jacobshandling
Copy link
Contributor

Great catches @jmwatts, thank you. To document what we discussed:

I've hidden the "Install details" tab on the My device page for now (see PR for details on reasoning and next steps).

Regarding varying information being returned and displayed, the UI is displaying whatever data it gets from the API. Whether or not the API is returning data as expected in various cases (Filepath, last used, etc.) is a question for product, so we're adding to the design review agenda. If it's working as expected, we're good, and if not, we can either call it a bug or a feature request and have that implemented on the next iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~frontend Frontend-related issue. #g-endpoint-ops Endpoint ops product group #g-software Software product group ~pushed User story was pushed to next release. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. story A user story defining an entire feature
Development

No branches or pull requests

7 participants