fleetctl preview: if license key invalid, hangs with no feedback

[mikermcneil]

Fleet version: fleetctl 4.53.1

---

💥  Actual behavior

🧑‍💻  Steps to reproduce

1. Run fleetctl preview --license-key bogus

🕯️ More info (optional)

N/A

🛠️ To fix

Figma

🦆 Test Plan

New functionality:

• Fails with proper error on --license-key set to various bogus values

Regresssion testing (see licenses embedded in serve.go ~L1331):

• Succeeds with valid license key
• Succeeds with expired license key (same as main app)
• Succeeds with no license key
• Succeeds with --license-key provided but nothing after it

[alexfornuto]

Lemme help fill out some deets

Problem

A user might not successfully copy the entire license key when running fleetctl commands that require it, or may supply a complete but otherwise invalid key. In these cases, the output hangs until cancelled with no error output.

Potential solutions

• before execution, check the size of the license key provided.
• during execution, if the key is invalid return exit non-zero with relevant error message to the terminal.

[rachaelshaw]

• @noahtalerman: User requested this because they want an easy to understand error message when they use an invalid license key when trying out Fleet for the first time.

[sharon-fdm]

Hey team! Please add your planning poker estimate with Zenhub @iansltx @lucasmrod @mostlikelee

[jmwatts]

@rachaelshaw I tested this with the fix in place, can you confirm the following is correct? Specifically the last test that said it should work actually does not and it gives me an error.

New functionality:

• [PASS] Fails with proper error on --license-key set to various bogus values
  Error: License key is invalid. Please check your license key and try again, or run fleetctl preview without the --license-key option to try Fleet Free.

Regression testing (see licenses embedded in serve.go ~L1331):

• [PASS] Succeeds with valid license key
• [PASS] Succeeds with expired license key (same as main app) [Get a lot of errors and banner in app though]
• [PASS] Succeeds with no license key
• [FAIL] Succeeds with --license-key provided but nothing after it [this tells me Error: flag needs an argument: -license-key]

[iansltx]

@jmwatts So, I was the one who added that test plan and I thought that the license key with no argument following it worked in v4.61.0, so i included it in the regression test. I was incorrect here; 4.61.0 hands back the same error when you don't provide an arg after the --license-key flag (which is fine; the command docs are clear that you need to add the license key in if you provide the flag).

I think what I meant to type there was --license-key "", which does work on 4.61.0, and should work on main.

[jmwatts]

@iansltx thanks for the clarification!
Just re-tested with --license-key '' and it worked. This one is good to go!

[fleet-release]

Invalid key hangs tight,
With feedback, users find light,
Fleet sails smooth and right.