Repository navigation
fix(reviews): upload review photos without a public ACL - #112
Merged
Merged
Conversation
The S3 media bucket enforces bucket-owner object ownership and rejects PUTs that carry an ACL, so put(..., 'public') returned false and no photo was stored.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2282 2282
===========================================
Files 182 182
Lines 9082 9082
===========================================
Hits 9082 9082
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of making Fleetbase work with a fully private S3 bucket. Companion to fleetbase/core-api#287 (full write-up there).
Review photos were uploaded with
'public'visibility (apublic-readACL). Buckets withObjectOwnership=BucketOwnerEnforcedreject ACL'd PUTs, andput()returnedfalsewithout an error, so the photo was never stored. The upload now goes out with no ACL;File::urlserves it signed.The test fake records write options and asserts that none are passed.