Repository navigation
fix(files): store signatures without a public ACL; re-sign stored avatar URLs - #353
Merged
Merged
Conversation
… avatar URLs - ProofController::storeSignature no longer passes 'public': the media bucket enforces bucket-owner ownership, rejects ACL'd PUTs, and put() silently returned false (no signature objects written since 2024-11-25). - Vehicle/Driver/Place avatar_url accessors re-sign legacy absolute bucket URLs via core-api File::signStoredUrl when available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 12379 12381 +2
===========================================
Files 600 600
Lines 46496 46498 +2
===========================================
+ Hits 46496 46498 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of making Fleetbase work with a fully private S3 bucket. Companion to fleetbase/core-api#287 (which has the full write-up).
ObjectOwnership=BucketOwnerEnforced.ProofController::storeSignature()wrote with'public'visibility (apublic-readACL). S3 rejects ACL'd PUTs on such buckets, andput()returnedfalsewithout an error, so the proof and File records were created but no object existed. The write now goes out with no ACL;File::urlserves it through a signed URL.avatar_urlon Vehicle, Driver and Place: legacy rows that hold an absolute bucket URL are re-signed at read time via core-apiFile::signStoredUrl(). On core-api releases that predate the helper, the value passes through unchanged.Tests: the signature-write fakes now assert that no visibility/ACL option is passed, and a pass-through test covers
Utils::signStoredFileUrl.