Repository navigation
style(login): use ember-ui's btn-auth for the Track Order button - #339
Merged
Merged
Conversation
The button was a link-style button with its border and padding on the wrapper and a 50% fade on hover. It is now a default block button with btn-auth, so it matches the console's "Continue with ..." buttons, including their hover, in light and dark. Needs @fleetbase/ember-ui with btn-auth. With an older ember-ui it falls back to a plain default block button.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=========================================
Coverage 99.99% 99.99%
Complexity 11936 11936
=========================================
Files 583 583
Lines 44892 44892
=========================================
Hits 44891 44891
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roncodes
added a commit
that referenced
this pull request
Sep 22, 2026
ember-ui 0.4.3 is published. It provides the btn-auth style the Track Order login button (#339) uses, so that button no longer falls back to a plain default button. pnpm-lock.yaml regenerated, and the v0.6.69 notes updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Track Order button on the console login page is now a default block button with ember-ui's
btn-auth. Before, it was a link-style button with its border and padding on the wrapper and a 50% fade on hover. It now matches the "Continue with ..." buttons, hover included, in light and dark.Depends on fleetbase/ember-ui#179. With an older ember-ui it falls back to a plain default block button, so nothing breaks.