Skip to content

Fix editing unsaved geocoded places in order form - #307

Merged
roncodes merged 1 commit into
dev-v0.6.61from
feature/fix-unsaved-geocoded-place-editing
Aug 31, 2026
Merged

roncodes merged 1 commit into
dev-v0.6.61from
feature/fix-unsaved-geocoded-place-editing

Conversation

@roncodes

Copy link
Copy Markdown
Member

Summary

  • convert geocoder-only place selections into new Ember Data records before attaching them to order routes, so editing and saving uses POST instead of PUT against a client-generated UUID
  • preserve existing persisted and already-new place records unchanged
  • allow serialized avatar_value and eta display fields during existing-place updates
  • add frontend record-lifecycle and backend update regression coverage

Validation

  • php scripts/pest-runner.php server/tests/Feature/Http/Internal/PlaceControllerTest.php
  • targeted ESLint for changed JavaScript files
  • PHP CS Fixer dry run for changed PHP files
  • git diff --check
  • PR CI enforces the fresh 100% Clover line-coverage gate

Fixes fleetbase/fleetbase#637

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (068be38) to head (196ac5f).

Additional details and impacted files
@@               Coverage Diff               @@
##             dev-v0.6.61      #307   +/-   ##
===============================================
  Coverage         100.00%   100.00%           
  Complexity          9899      9899           
===============================================
  Files                526       526           
  Lines              38163     38163           
===============================================
  Hits               38163     38163           
Flag Coverage Δ
backend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roncodes
roncodes merged commit a764a68 into dev-v0.6.61 Aug 31, 2026
8 checks passed
@roncodes
roncodes deleted the feature/fix-unsaved-geocoded-place-editing branch August 31, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant