Repository navigation
feat(oauth): add OauthProviderButton and OauthProviderLogo - #182
Merged
Merged
Conversation
A "Continue with <provider>" button for sign-in and sign-up pages: a btn-auth block button with the provider's logo in the icon slot at the far left, re-coloured where a provider's guidelines call for it. Google and Microsoft stay on btn-auth's white with their full-colour logos. Apple is black and GitHub near-black. Every provider is gray-900 in dark mode, where Google's G sits on the white disc Google requires. Moved here from the console so the Fleetbase Cloud sign-up page, which is an engine component and can't use console components, can render the same buttons. RELEASE.md adds it to v0.4.3.
roncodes
added a commit
to fleetbase/fleetbase
that referenced
this pull request
Sep 22, 2026
Signing up with a provider already worked, but the only way in was the
login page's "Continue with ..." buttons. The sign-up page ("Create a new
Account") now offers the same buttons above the form, then "Or sign up
with email".
- They show only when a provider is enabled and an administrator allows
sign-ups through one (the new `allow_registration` in the provider
list), and not once the form is already prefilled from a provider.
- Pressing one starts the usual handshake with `intent: 'signup'`. An
unknown identity comes back to the prefilled form as before. Someone
who already has an account is signed in and told "You already have an
account, so we signed you in."
- The login page, the sign-up page and the connected-accounts panel now
use ember-ui's OauthProviderButton and OauthProviderLogo
(fleetbase/ember-ui#182, v0.4.3). The console's own logo component and
provider button CSS are removed.
Needs @fleetbase/ember-ui 0.4.3; bump the dependency once it is released.
roncodes
added a commit
to fleetbase/fleetbase
that referenced
this pull request
Sep 22, 2026
Signing up with a provider already worked, but the only way in was the
login page's "Continue with ..." buttons. The sign-up page ("Create a new
Account") now offers the same buttons above the form, then "Or sign up
with email".
- They show only when a provider is enabled and an administrator allows
sign-ups through one (the new `allow_registration` in the provider
list), and not once the form is already prefilled from a provider.
- Pressing one starts the usual handshake with `intent: 'signup'`. An
unknown identity comes back to the prefilled form as before. Someone
who already has an account is signed in and told "You already have an
account, so we signed you in."
- The login page, the sign-up page and the connected-accounts panel now
use ember-ui's OauthProviderButton and OauthProviderLogo
(fleetbase/ember-ui#182, v0.4.3). The console's own logo component and
provider button CSS are removed.
Needs @fleetbase/ember-ui 0.4.3; bump the dependency once it is released.
roncodes
added a commit
to fleetbase/fleetbase
that referenced
this pull request
Sep 23, 2026
Signing up with a provider already worked, but the only way in was the
login page's "Continue with ..." buttons. The sign-up page ("Create a new
Account") now offers the same buttons above the form, then "Or sign up
with email".
- They show only when a provider is enabled and an administrator allows
sign-ups through one (the new `allow_registration` in the provider
list), and not once the form is already prefilled from a provider.
- Pressing one starts the usual handshake with `intent: 'signup'`. An
unknown identity comes back to the prefilled form as before. Someone
who already has an account is signed in and told "You already have an
account, so we signed you in."
- The login page, the sign-up page and the connected-accounts panel now
use ember-ui's OauthProviderButton and OauthProviderLogo
(fleetbase/ember-ui#182, v0.4.3). The console's own logo component and
provider button CSS are removed.
Needs @fleetbase/ember-ui 0.4.3; bump the dependency once it is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
<OauthProviderButton>and<OauthProviderLogo>for v0.4.3.It's a
btn-authblock button (from #179) with the provider's logo in the usual icon slot at the far left. Some providers get their own colours as re-colourings of the--btn-auth-*variables. The hover and border stay the same for all.#24292FWhy in ember-ui: these buttons currently live in the console. The Fleetbase Cloud sign-up page is an engine component (internals) and can't render console components. Moving them here lets the console login page, the console sign-up page and the Cloud sign-up page share one set of buttons.
Tests: integration tests for both components cover the logos, where the logo sits, the text, and clicks, including disabled.
RELEASE.mdnow lists this under v0.4.3 (#181).Used by fleetbase/fleetbase#672 (login and sign-up pages) and fleetbase/internals#52 (Cloud sign-up).