Repository navigation
Conversation
roncodes
added a commit
that referenced
this pull request
Oct 3, 2026
Live defects: - crud: bulk-action message no longer doubles the count (#2); the import queue is an Ember array (#11); the modelName option overrides the model's own name in dialogs and the bulk endpoint (#26) - fetch: a bare Content-Type is parsed (#5); a caller's filename wins over content-disposition (#15) - filters: Ember's mapped query-param form is unwrapped to property names (#4) - registry-service: classes are keyed, so they can be looked up (#6); only a Helper subclass is instantiated, however a function helper is written (#12) - universe facade: list names are passed, menu readers ask the menu service, dashboardWidgets reads the 'dashboard' dashboard (#7) - current-user: loadWhois warns when the lookup fell back (#8) - session: promiseCurrentUser aborts and invalidates once (#9); seconds remaining is expiry minus now (#10) - chat: remembering an open channel keeps the list (#13) - subject-custom-fields: writeFieldValue checks for a field first (#14) Latent and behavioural: - MenuItem's chaining setter is withOnClick(); onClick stays the handler (#24) - organization and user account menus are separated by key prefix (#25) - #26: '~'-slug menu items get unique registry keys; transitionMenuItem carries query params; replace-table-row handles index 0 and misses; get-mime-type returns mime types for whole extensions; custom-field panels keep merged saveOptions; sameIds gets its options; loadSubjectCustomFields rethrows (9 of 10 callers already catch); the stub utils do what their names say; legacy-from-store re-exports from-store; legacy-fetch-from reads null until loaded on native class fields Also: fetch.cachedGet never expired a cache exactly a month old (it compared the 'days' component of intervalToDuration); expiry is now elapsed time. The make-dataset tests no longer depend on the machine's timezone. Every pin is rewritten to assert the fixed behaviour. 2319 tests pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.