Repository navigation
feat: record app and APNs environment on user devices - #276
Merged
Merged
Conversation
Add optional app_identifier, environment and last_seen_at columns to user_devices so push senders can pick the credentials of the app a token was registered from and the APNs environment that issued it, instead of guessing. All columns are nullable and guarded, and callers that do not set them keep working.
8 of 16 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 7499 7499
===========================================
Files 430 430
Lines 24488 24488
===========================================
Hits 24488 24488
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Sep 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three optional, nullable columns to
user_devices, and makes them fillable onUserDevice:app_identifier(indexed)environmentproduction/sandbox), so it is sent to the right APNs host instead of being rejected withBadDeviceTokenlast_seen_atThis supports the Storefront push notification fix (fleetbase/storefront
fix/push-notification-layer). Storefront only writes these columns when they exist, so the two PRs can ship in either order.Validation
Schema::hasColumn;down()drops only existing columns.php -lpasses on both files, and the PHP formatter (php-cs-fixer --dry-run) reports 0 changes.Risk
Low. This adds nullable columns to
user_devices; existing reads and writes are unchanged.