Repository navigation
fix(push): send FCM order notifications with android high priority - #273
Merged
Merged
Conversation
Without an explicit android.priority, Android held order pushes while the device was in deep Doze and delivered them only when the phone was unlocked or charged. Closes #268 (cherry picked from commit 5bd2ba9232c4f7fced8d502f07ab0906418d3368)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 7499 7499
===========================================
Files 430 430
Lines 24488 24489 +1
===========================================
+ Hits 24488 24489 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268.
Why
PushNotification::createFcmMessage()built FCM messages without an Android priority. Android held order pushes (OrderAssigned,OrderDispatched, …) while a driver's phone was in deep Doze, and delivered them only once the phone was unlocked or charged. FCM still accepted the message, so nothing on the server reported a problem.The reporter ran a controlled test on the same device after about 60 minutes locked: the message as built today was not delivered, and the same message with
android.priority = higharrived immediately.What changed
createFcmMessage()setsandroid.priority = high. These are user-visible, time-sensitive notifications, which is the case FCM documents high priority for.apns-priority: 10.Verification
PushNotificationTest,NotificationsAndMailTest) now expectpriority: high.Storefront builds its own FCM messages (
storefront/server/src/Support/PushNotification.php), which probably needs the same change in that repo.