Add bubblewrap support for running nix2gpu without a container runtime#12
Open
baileylu121 wants to merge 12 commits intomainfrom
Open
Add bubblewrap support for running nix2gpu without a container runtime#12baileylu121 wants to merge 12 commits intomainfrom
baileylu121 wants to merge 12 commits intomainfrom
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nix flake update + switch nimi feature branch
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add bubblewrap support for running nix2gpu without a container runtime
This PR updates the flake dependencies and switches from the
baileylu/minimize-flakebranch to thebaileylu/bubblewrapbranch of nimi.Allow creation of the template
Adds a templates module and renames the basic template to default, making it available via
nix flake init -t github:weyl-ai/nix2gpu.Fix typo
Fixes a missing colon in the getting-started.md documentation.
Bind to nimi's bubblewrap with equivalency to the container config
Adds bubblewrap configuration to match container behavior, allowing nix2gpu containers to run in bubblewrap sandboxes. This includes:
Optimize the calling to only evaluate the nimi module once
Refactors the container creation to evaluate the nimi module once and reuse the configuration for both container image and bubblewrap.
Properly bind gpu drivers
Adds comprehensive GPU device bindings for NVIDIA devices and configures the proper procfs access needed for GPU drivers to function in bubblewrap.
Note
Medium Risk
Touches core container build/startup paths and bumps key flake dependencies (including
nixpkgsandnimi), which can affect runtime behavior and compatibility across environments.Overview
Adds bubblewrap mode support so
nix2gpuinstances can run via a newrunInBubblewrapwrapper without Docker/Podman, including automaticcopyToRootbind-mounting, env/user/working-dir translation, and extensive NVIDIA library/device +/prochandling.Updates startup/init behavior for bubblewrap (tmpfs dirs, populating
/etc, SSH port rewrite to2222, root auth handling), adds a NixOS check to exercise bubblewrap execution, and tweaks the container-runtime check to expose SSH. Documentation is expanded with a newdocs/bubblewrap.md, and the repo adds aflake.templates.defaulttemplate plus bumpsnixpkgs/nimi(switching tobaileylu/bubblewrap) and other flake inputs.Written by Cursor Bugbot for commit d27b0b8. This will update automatically on new commits. Configure here.