better way to prevent overwritten base properties on errors.

fleebeee · Oct 29, 2015 · 5f062c8 · 5f062c8
1 parent 397bb36
commit 5f062c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/errors.js b/lib/errors.js
@@ -13,7 +13,7 @@ function EbayClientError(message, extraProps) {
   Error.captureStackTrace(this, this.constructor);
   this.name = this.constructor.name;
   this.message = message;
-  _.extend(this, _.omit(extraProps, ['name', 'message']));
+  _.defaults(this, extraProps);
 }
 inherits(EbayClientError, Error);
 

diff --git a/test/errors.test.js b/test/errors.test.js
@@ -61,12 +61,13 @@ describe('error classes', function() {
       it('can\'t overwrite base properties with extra properties', function() {
         var err = new errorClass('Original message', {
           message: 'New message',
-          name: 'UhOh'
+          name: 'UhOh',
+          stack: 'ByeBye'
         });
 
         expect(err.message).to.equal('Original message');
         expect(err.name).to.equal(errorClassName);
-
+        expect(err.stack).not.to.equal('ByeBye');
       });
 
     });