feat: 2076 - new optimizeRadiusInMeters parameter for CircleLayer #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `circle_layer.dart`: new `bool optimizeRadiusInMeters` field * `many_circles.dart`: now displaying radius of 100km (instead of 5 pixels), with `optimizeRadiusInMeters: true` * `painter.dart`: caching the meter in pixels value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
useRadiusInMeterparameter, we compute again and again the radius of eachCircleMarker. Which depends on its latitude and requires heavy computation.optimizeRadiusInMetersparameter forCircleLayer, we are able to cache the number of pixels per meter, and to compute the value once for all markers.CircleMarkers doesn't freeze anymore.useRadiusInMetersoption toCircleLayer#2076Impacted files
circle_layer.dart: newbool optimizeRadiusInMetersfieldmany_circles.dart: now displaying radius of 100km (instead of 5 pixels), withoptimizeRadiusInMeters: truepainter.dart: caching the meter in pixels value