Skip to content

fix: calculate LayerHitResult.coordinate correctly #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JaffaKetchup
Copy link
Member

Fixes #2092.

Also added .coordinate demo to Polygons example.

I also removed FeatureLayerUtils.origin in favour of MapCamera.pixelOrigin. I'm not 100% if this is correct, but it seems to make sense.

Added `.coordinate` demo to Polygons example
Removed `FeatureLayerUtils.origin` in favour of `MapCamera.pixelOrigin`
@JaffaKetchup JaffaKetchup requested a review from a team May 16, 2025 10:36
@JaffaKetchup
Copy link
Member Author

@monsieurtanuki I believe it was while we were messing about with the feature layer painting that origin ended up in FeatureLayerUtils. In this PR, I've removed it because I couldn't see a difference to MapCamera.origin. They seem to work the same, but maybe you had something in mind to put origin in FeatureLayerUtils as well (caching messing something up?)? Does this change seem OK to you?

@monsieurtanuki
Copy link
Contributor

@JaffaKetchup I'll try to have a look at it this week. Sorry about the delay.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hit notifier returns incorrect LayerHitResult.coordinate when rotated
2 participants