Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added polygon validity check before hit testing #1964

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

JaffaKetchup
Copy link
Member

Fixes #1933 using method suggested by @mootw (and which I think also makes sense).

Copy link
Collaborator

@mootw mootw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the assertion, but it does not seem to resolve the random streaking on polygons that are simplified, i'm happy to merge this in and then fix the other issue separately. i am not even entirely sure when the issue started showing up anywhos

@JaffaKetchup
Copy link
Member Author

Yep, we should fix that in another PR, I'll open a new issue. Thanks!

@JaffaKetchup JaffaKetchup merged commit cb6d6a0 into master Sep 12, 2024
8 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-1933 branch September 12, 2024 19:00
TesteurManiak

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Hit testing Polygon with less than 3 points fails assertion
3 participants