Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained MediaQuery dependencies to rebuild only when needed #1523

Merged
merged 1 commit into from
May 14, 2023

Conversation

ignatz
Copy link
Contributor

@ignatz ignatz commented May 12, 2023

Previously, the broad dependency triggered rebuilds when the keyboard came up even when rendered in a Scaffold() with resizeToAvoidBottomInset set to false. This caused a lot of jank for me, i.e. triggering full-map-rebuilds at animation pace.

Previously, the broad dependency triggered rebuilds when the keyboard came up even when rendered in a Scaffold() with resizeToAvoidBottomInset set to false. This caused a lot of jank for me, i.e. triggering full-map-rebuilds at animation pace.
Copy link
Collaborator

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks a lot for the added test case 👍

@TesteurManiak TesteurManiak self-assigned this May 14, 2023
@JaffaKetchup JaffaKetchup merged commit 7538c66 into fleaflet:master May 14, 2023
@JaffaKetchup
Copy link
Member

(Untested by myself.)
Thanks @ignatz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants